Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(workspaces): implement src as workspace package (#1178) #1198

Merged
merged 2 commits into from
Jun 8, 2021

Conversation

nickofthyme
Copy link
Collaborator

Backports the following commits to master:

Key changes:
- move `./src/**` to `./packages/elastic-charts/**`
- correct all paths due to file sturcture changes
- fix bad docs paths and config options
- create top-level mono package, move lib package
- simplify lib tsconfig.json files
- fix errors in linking package, cleanup paths
- fix linting config to reflect file structure changes
- update semantic release to point at new lib package
- add lerna to facilitate running workspace scripts
@nickofthyme nickofthyme changed the title build(workspaces): implement src as workspace package (#1178) [master] build(workspaces): implement src as workspace package (#1178) Jun 8, 2021
@nickofthyme
Copy link
Collaborator Author

Verified release functions as normal. Installed released alpha version in kibana without issue.

I noticed some top-level .txt and .md files were not being included so for the time being (i.e. before moving to esbuild, etc) I added a copy step to the build process.

@nickofthyme nickofthyme merged commit 915595f into elastic:master Jun 8, 2021
@nickofthyme nickofthyme deleted the backport/master/pr-1178 branch June 8, 2021 22:26
@nickofthyme
Copy link
Collaborator Author

🎉 This PR is included in version 30.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport released Issue released publicly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant