fix(metric): icon alignment defaults #2489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
buildkite update screenshots |
nickofthyme
pushed a commit
that referenced
this pull request
Jul 15, 2024
# [66.1.0](v66.0.5...v66.1.0) (2024-07-15) ### Bug Fixes * **deps:** update dependency @elastic/eui to ^95.3.0 ([#2479](#2479)) ([d8c8a6a](d8c8a6a)) * **deps:** update dependency @playwright/test to ^1.45.0 ([#2480](#2480)) ([6b9935c](6b9935c)) * **deps:** update dependency @playwright/test to ^1.45.1 ([#2485](#2485)) ([8fe29f5](8fe29f5)) * **deps:** update dependency json-schema-to-typescript to v14.1.0 ([#2481](#2481)) ([b459a76](b459a76)) * **metric:** icon alignment defaults ([#2489](#2489)) ([bba76fa](bba76fa)) ### Features * **metric:** make value fit logic uniform across panels ([#2484](#2484)) ([991347d](991347d))
nickofthyme
added a commit
to nickofthyme/elastic-charts
that referenced
this pull request
Jul 15, 2024
# Conflicts: # e2e/screenshots/all.test.ts-snapshots/baselines/metric-alpha/grid-chrome-linux.png # e2e/screenshots/chart.test.ts-snapshots/chart/sizing/should-accommodate-chart-title-and-description-metric-sm-chrome-linux.png # e2e/screenshots/metric_stories.test.ts-snapshots/metric/should-render-horizontal-progress-bar-chrome-linux.png # e2e/screenshots/metric_stories.test.ts-snapshots/metric/should-render-horizontal-progress-bar-in-dark-mode-chrome-linux.png # e2e/screenshots/metric_stories.test.ts-snapshots/metric/should-render-no-progress-bar-chrome-linux.png # e2e/screenshots/metric_stories.test.ts-snapshots/metric/should-render-no-progress-bar-in-dark-mode-chrome-linux.png # e2e/screenshots/metric_stories.test.ts-snapshots/metric/should-render-vertical-progress-bar-in-dark-mode-chrome-linux.png # e2e/screenshots/metric_stories.test.ts-snapshots/metric/should-render-with-empty-and-missing-background-colors-chrome-linux.png
nickofthyme
added a commit
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
iconAligndefault onMetricto right.Details
In #2437 we set the
iconAligndefaults to theleftwhich was broke the previous default of it being aligned to the right of the titles.Checklist
:xy,:partition):interactions,:axis)