fix(flame): failure when accessing visualViewport.visualViewport from within iFrame
#2502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickofthyme
added
bug
dej611
reviewed
Aug 8, 2024
dej611
reviewed
Aug 9, 2024
dej611
approved these changes
Aug 9, 2024
nickofthyme
pushed a commit
that referenced
this pull request
Aug 9, 2024
## [66.1.1](v66.1.0...v66.1.1) (2024-08-09) ### Bug Fixes * **deps:** update dependency @elastic/eui to ^95.5.0 ([#2496](#2496)) ([803a56a](803a56a)) * **deps:** update dependency @playwright/test to ^1.45.3 ([#2495](#2495)) ([4b82ee2](4b82ee2)) * **deps:** update dependency json-schema-to-typescript to v15 ([#2497](#2497)) ([d635ebb](d635ebb)) * **flame:** failure when accessing `visualViewport.visualViewport` from within `iFrame` ([#2502](#2502)) ([84f5328](84f5328))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue where the
Flamechart was attempting to accesswindow.visualViewportfrom within an iframe.Details
The
Flamechart was attempting to access thewindow.visualViewportof the top mostwindowfrom an iframe. However this triggered aDOMExceptionerror as thevisualViewportproperty is forbidden expect when accessed by the topwindowcontext, for cross-origins.We were only updating this value every
100msto capture the latestpinchZoomScale. Since this is not accessible from an iframe I elected to simply disable this update loop when in the iframe and access the value in place directly fromwindow.visualViewport?.scale;Now renders fine within iframe 👇🏼
Issues
Related to elastic/kibana#188288
Checklist
:xy,:partition)