fix(line_annotation): keep the spec in state after chart rerender #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `LineAnnotation` component doesn't use the `specComponentFactory` because it render the marker if available. We have to always keep the spec updating the state on every lifecycle thus removing the deepEqual check on the shouldComponentUpdate did the trick. fix elastic#604
Codecov Report
@@ Coverage Diff @@
## master #605 +/- ##
=========================================
Coverage ? 70.79%
=========================================
Files ? 220
Lines ? 6409
Branches ? 1224
=========================================
Hits ? 4537
Misses ? 1853
Partials ? 19
Continue to review full report at Codecov.
|
monfera
approved these changes
Mar 25, 2020
markov00
pushed a commit
that referenced
this pull request
Mar 26, 2020
# [18.2.0](v18.1.0...v18.2.0) (2020-03-26) ### Bug Fixes * **line_annotation:** keep the spec in state after chart rerender ([#605](#605)) ([43c13f1](43c13f1)), closes [#604](#604) ### Features * **partition:** stroke configuration and linked label value font format ([#602](#602)) ([7dce0a3](7dce0a3))
|
🎉 This PR is included in version 18.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 18.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [18.2.0](elastic/elastic-charts@v18.1.0...v18.2.0) (2020-03-26) ### Bug Fixes * **line_annotation:** keep the spec in state after chart rerender ([opensearch-project#605](elastic/elastic-charts#605)) ([22296c6](elastic/elastic-charts@22296c6)), closes [opensearch-project#604](elastic/elastic-charts#604) ### Features * **partition:** stroke configuration and linked label value font format ([opensearch-project#602](elastic/elastic-charts#602)) ([24d0e71](elastic/elastic-charts@24d0e71))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
LineAnnotationcomponent doesn't use thespecComponentFactorybecause it render the markerif available. We have to always keep the spec updating the state on every lifecycle thus removing
the deepEqual check on the shouldComponentUpdate did the trick.
fix #604
Checklist
Delete any items that are not applicable to this PR.