Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(interactions): recognise drag after 100ms and 4px #848

Merged
merged 5 commits into from
Oct 6, 2020
Merged

fix(interactions): recognise drag after 100ms and 4px #848

merged 5 commits into from
Oct 6, 2020

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Oct 5, 2020 •
edited
Loading

Summary

This fix reduces the situation where a drag event is fired instead of a click one.
The fix adds the following thresholds:

  • a 100ms threshold before the mouse-down time and the current time to consider the movement for dragging purposes
  • a 4-pixel delta between mouse-down and the current position to consider the movement for dragging purposes

fix #748

Checklist

  • Unit tests were updated or added to match the most common scenarios

@markov00
fix(interactions): recognize drag action only after 100ms
0304f50 
This fix reduce the situation where a click is not recognized and instead a drag event is detected.
Adding a 100ms threshold allows a better click handling on situation where a mouse move event occurs
during a mouse click

fix elastic#748
@markov00 markov00 added bug Something isn't working :interactions Interactions related issue labels Oct 5, 2020
@markov00 markov00 requested a review from darnautov October 5, 2020 15:55
nickofthyme
nickofthyme approved these changes Oct 5, 2020
View reviewed changes
Copy link
Collaborator

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally.

darnautov
darnautov approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM! Just one suggestion about the constant.
It's worth slightly change the PR description by mentioning the delta also taken into account.

@markov00 markov00 changed the title fix(interactions): recognize drag action only after 100ms fix(interactions): recognise drag after 100ms and 4px Oct 6, 2020
@markov00 markov00 merged commit 70626fe into elastic:master Oct 6, 2020
@markov00 markov00 deleted the 2020_10_05-fix_interaction_time branch October 6, 2020 08:08
markov00 pushed a commit that referenced this pull request Oct 6, 2020
@semantic-release-bot
chore(release): 23.2.0 [skip ci]
0fa084d 
# [23.2.0](v23.1.1...v23.2.0) (2020-10-06)

### Bug Fixes

* **heatmap:** adjust pageSize based available chart height ([#849](#849)) ([9aa396b](9aa396b))
* **heatmap:** destroy canvas bbox calculator when done ([#844](#844)) ([42460bd](42460bd))
* **heatmap:** x-axis labels overlapping for time series data ([#850](#850)) ([9ebd879](9ebd879))
* **interactions:** recognise drag after 100ms and 4px ([#848](#848)) ([70626fe](70626fe)), closes [#748](#748)

### Features

* heatmap tooltip enhancements and fixes ([#847](#847)) ([d879e05](d879e05))
@markov00
Copy link
Member Author

markov00 commented Oct 6, 2020

🎉 This PR is included in version 23.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Oct 6, 2020
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 23.2.0 [skip ci]
734535a 
# [23.2.0](elastic/elastic-charts@v23.1.1...v23.2.0) (2020-10-06)

### Bug Fixes

* **heatmap:** adjust pageSize based available chart height ([opensearch-project#849](elastic/elastic-charts#849)) ([fd56099](elastic/elastic-charts@fd56099))
* **heatmap:** destroy canvas bbox calculator when done ([opensearch-project#844](elastic/elastic-charts#844)) ([4c1fd55](elastic/elastic-charts@4c1fd55))
* **heatmap:** x-axis labels overlapping for time series data ([opensearch-project#850](elastic/elastic-charts#850)) ([7cbd151](elastic/elastic-charts@7cbd151))
* **interactions:** recognise drag after 100ms and 4px ([opensearch-project#848](elastic/elastic-charts#848)) ([f7aa7f8](elastic/elastic-charts@f7aa7f8)), closes [opensearch-project#748](elastic/elastic-charts#748)

### Features

* heatmap tooltip enhancements and fixes ([opensearch-project#847](elastic/elastic-charts#847)) ([6d763fb](elastic/elastic-charts@6d763fb))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darnautov darnautov darnautov approved these changes

@nickofthyme nickofthyme nickofthyme approved these changes

Assignees
No one assigned
Labels
bug Something isn't working :interactions Interactions related issue released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Click interactions with moving mouse pointer are not recognised
3 participants
@markov00 @darnautov @nickofthyme