Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we eagerly return the outbound array to the array pool #52

Merged
merged 6 commits into from
Apr 9, 2024

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Apr 8, 2024

This PR moves our using of buffer inside the task that consumes it, making it easier for the GC to track and eagerly dispose and hence return the rented memory.

Copy link
Contributor

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mpdreamz Mpdreamz merged commit 2cdc188 into main Apr 9, 2024
4 checks passed
@Mpdreamz Mpdreamz deleted the fix/eager-array-return branch April 9, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants