Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import hard-coded list of common fields #1025

Closed
wants to merge 2 commits into from

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented Nov 4, 2022

Relates #1018

This PR adds in build time a new file fields/imported_elastic_package.yml with a list of common fields (hard-coded in the code).

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 4, 2022

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-04T13:38:23.117+0000

  • Duration: 31 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 799
Skipped 0
Total 799

Steps errors 3

Expand to view the steps failures

Check
  • Took 1 min 10 sec . View more details here
  • Description: make install test-check-packages-other check-git-clean
Check
  • Took 1 min 14 sec . View more details here
  • Description: make install test-build-zip check-git-clean
Build elastic-package
  • Took 0 min 11 sec . View more details here
  • Description: make PACKAGE_UNDER_TEST=apache test-check-packages-parallel

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Collaborator

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (30/30) 💚
Files 66.393% (81/122) 👎 -0.273
Classes 61.017% (108/177) 👎 -0.396
Methods 45.892% (324/706) 👎 -1.77
Lines 29.384% (3048/10373) 👎 -1.339
Conditionals 100.0% (0/0) 💚

Comment on lines +91 to +119
- external: ecs
name: threat.enrichments.indicator.geo.continent_name
- external: ecs
name: threat.enrichments.indicator.geo.country_iso_code
- external: ecs
name: threat.enrichments.indicator.geo.region_name
- external: ecs
name: threat.enrichments.indicator.geo.region_iso_code
- external: ecs
name: threat.enrichments.indicator.geo.city_name
- external: ecs
name: threat.enrichments.indicator.geo.name
- external: ecs
name: threat.enrichments.indicator.geo.location

- external: ecs
name: threat.indicator.geo.continent_name
- external: ecs
name: threat.indicator.geo.country_iso_code
- external: ecs
name: threat.indicator.geo.region_name
- external: ecs
name: threat.indicator.geo.region_iso_code
- external: ecs
name: threat.indicator.geo.city_name
- external: ecs
name: threat.indicator.geo.name
- external: ecs
name: threat.indicator.geo.location
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason why threat would need to be included in this? Especially threat.enrichments which would not exist in any datastream outside the ones generated by SIEM rules (alerts indices).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the proposed fields to be hardcoded #1018 (comment), there were some ecs external fields like geo.*. However, among the ecs fields there are no fields that start with ^geo.*. Therefore, as a first approach, I just tried to include all the geo fields that I found here: https://github.com/elastic/ecs/blob/main/generated/ecs/ecs_flat.yml

@mrodm
Copy link
Contributor Author

mrodm commented Dec 20, 2022

Closing this PR in favor of #1073

@mrodm mrodm closed this Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants