-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import hard-coded list of common fields #1025
Conversation
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
🌐 Coverage report
|
- external: ecs | ||
name: threat.enrichments.indicator.geo.continent_name | ||
- external: ecs | ||
name: threat.enrichments.indicator.geo.country_iso_code | ||
- external: ecs | ||
name: threat.enrichments.indicator.geo.region_name | ||
- external: ecs | ||
name: threat.enrichments.indicator.geo.region_iso_code | ||
- external: ecs | ||
name: threat.enrichments.indicator.geo.city_name | ||
- external: ecs | ||
name: threat.enrichments.indicator.geo.name | ||
- external: ecs | ||
name: threat.enrichments.indicator.geo.location | ||
|
||
- external: ecs | ||
name: threat.indicator.geo.continent_name | ||
- external: ecs | ||
name: threat.indicator.geo.country_iso_code | ||
- external: ecs | ||
name: threat.indicator.geo.region_name | ||
- external: ecs | ||
name: threat.indicator.geo.region_iso_code | ||
- external: ecs | ||
name: threat.indicator.geo.city_name | ||
- external: ecs | ||
name: threat.indicator.geo.name | ||
- external: ecs | ||
name: threat.indicator.geo.location |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason why threat would need to be included in this? Especially threat.enrichments which would not exist in any datastream outside the ones generated by SIEM rules (alerts indices).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the proposed fields to be hardcoded #1018 (comment), there were some ecs external fields like geo.*
. However, among the ecs fields there are no fields that start with ^geo.*
. Therefore, as a first approach, I just tried to include all the geo fields that I found here: https://github.com/elastic/ecs/blob/main/generated/ecs/ecs_flat.yml
Closing this PR in favor of #1073 |
Relates #1018
This PR adds in build time a new file
fields/imported_elastic_package.yml
with a list of common fields (hard-coded in the code).