Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System benchmarks improvements #1340

Merged
merged 28 commits into from
Aug 23, 2023

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Jul 4, 2023

This PR adds several new functionalities to the system benchmarks:

  • Support for k8s and tf service deployers
  • Support for service deployer variants
  • Support to set an external metricstore to send metrics during the benchmark
  • Support to reindex the benchmark data to the metricstore
  • Support custom policy_template setting

@marc-gr
Copy link
Contributor Author

marc-gr commented Jul 4, 2023

/test

@marc-gr marc-gr force-pushed the system-benchmarks-improvements branch from ced067c to cbf7ed6 Compare July 6, 2023 08:52
@marc-gr
Copy link
Contributor Author

marc-gr commented Jul 6, 2023

test integrations

@elasticmachine
Copy link
Collaborator

Created or updated PR in integrations repostiory to test this vesrion. Check elastic/integrations#6838

@marc-gr marc-gr force-pushed the system-benchmarks-improvements branch 2 times, most recently from d7686a9 to 14d3582 Compare July 6, 2023 13:21
@marc-gr marc-gr force-pushed the system-benchmarks-improvements branch from 14d3582 to 5fa9987 Compare July 7, 2023 09:18
@marc-gr marc-gr marked this pull request as ready for review July 7, 2023 09:27
@marc-gr
Copy link
Contributor Author

marc-gr commented Jul 7, 2023

/test

@sharbuz
Copy link
Contributor

sharbuz commented Jul 10, 2023

Hi everyone,
Please update the branch because we merged an important change to the main branch: #1347

@marc-gr marc-gr requested review from jsoriano, ebeahan and mrodm August 21, 2023 10:25
@marc-gr
Copy link
Contributor Author

marc-gr commented Aug 21, 2023

test integrations

@elasticmachine
Copy link
Collaborator

Created or updated PR in integrations repostiory to test this vesrion. Check elastic/integrations#7472

@marc-gr
Copy link
Contributor Author

marc-gr commented Aug 22, 2023

test integrations

@elasticmachine
Copy link
Collaborator

Created or updated PR in integrations repostiory to test this vesrion. Check elastic/integrations#7484

@marc-gr
Copy link
Contributor Author

marc-gr commented Aug 22, 2023

/test

@marc-gr
Copy link
Contributor Author

marc-gr commented Aug 22, 2023

test integrations

@elasticmachine
Copy link
Collaborator

Created or updated PR in integrations repostiory to test this vesrion. Check elastic/integrations#7489

cmd/benchmark.go Outdated Show resolved Hide resolved
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @marc-gr

@marc-gr marc-gr requested a review from mrodm August 22, 2023 14:44
@marc-gr marc-gr merged commit d369b9e into elastic:main Aug 23, 2023
@marc-gr marc-gr deleted the system-benchmarks-improvements branch August 23, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants