Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy all files for terraform system tests #603

Merged
merged 2 commits into from
Dec 6, 2021
Merged

copy all files for terraform system tests #603

merged 2 commits into from
Dec 6, 2021

Conversation

endorama
Copy link
Member

@endorama endorama commented Dec 1, 2021

Terraform allows using files from the local folder for different use cases.

The current implementation of the deployer prevents this by copying only *.tf files from the stage folder to the workspace folder.

This PR update the script to copy all files.

I have a use case behind this change: to test GCP BigQuery a schema and some test data must be provided. The schema and data are in JSON format, but with the current implementation is not possible to use them as they do not get copied over.

Terraform allows using files from the local folder for different use
cases.

The current implementation of the deployer prevents this by copying only
*.tf files from the stage folder to the workspace folder.

This commit update the script to copy all files.
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 1, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-02T15:25:37.494+0000

  • Duration: 36 min 31 sec

  • Commit: 7b3f15f

Test stats 🧪

Test Results
Failed 0
Passed 452
Skipped 4
Total 456

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@endorama endorama requested a review from mtojek December 2, 2021 11:25
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we can easily test this change without the GCP package, so let's push it so far.

@mtojek
Copy link
Contributor

mtojek commented Dec 2, 2021

Feel free to merge this PR!

@mtojek mtojek merged commit 483f09e into elastic:master Dec 6, 2021
@endorama endorama deleted the terraform-deployer-files branch September 28, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants