Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use program data in Beats MSI installers #234

Closed
wants to merge 3 commits into from

Conversation

cmacknz
Copy link
Member

@cmacknz cmacknz commented Feb 1, 2024

Store configuration, runtime, and log data in ProgramFiles.

@cmacknz cmacknz self-assigned this Feb 1, 2024
@cmacknz cmacknz marked this pull request as ready for review February 1, 2024 20:35
@cmacknz cmacknz requested a review from a team as a code owner February 1, 2024 20:35
@cmacknz
Copy link
Member Author

cmacknz commented Feb 1, 2024

buildkite test it

amitkanfer
amitkanfer previously approved these changes Feb 1, 2024
Copy link
Contributor

@amitkanfer amitkanfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmacknz
Copy link
Member Author

cmacknz commented Feb 1, 2024

Buildkite doesn't actually seem to be running for this branch, hmm. https://buildkite.com/elastic/elastic-stack-installers

@dliappis
Copy link
Contributor

dliappis commented Feb 5, 2024

Buildkite doesn't actually seem to be running for this branch, hmm. https://buildkite.com/elastic/elastic-stack-installers

@cmacknz this is expected, to be fixed by #235 ; for now just use "Merge without waiting for requirements to be met (bypass branch protections)"

@cmacknz
Copy link
Member Author

cmacknz commented Feb 6, 2024

For users that are using the MSI to upgrade Beats in place, this will be a breaking change because the local Filebeat/Winlogbeat/etc registries are discarded. This will cause previously invested data to be ingested again.

Edit: our MSI does not support upgrading, only installing again.

@dliappis
Copy link
Contributor

dliappis commented Feb 7, 2024

buildkite test this

@cmacknz
Copy link
Member Author

cmacknz commented Feb 8, 2024

Closing in favor of #238

@cmacknz cmacknz closed this Feb 8, 2024
@cmacknz cmacknz deleted the do-not-use-program-data branch February 8, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants