Use version from MANIFEST_URL #274
Conversation
This commit derives the version directly from the MANIFEST_URL env var rather than rely on `StackVersion` defined in `Directory.Build.Props`. Closes #271
dliappis
force-pushed
the
honor-version-from-stack-url
branch
from
812d6e2 to
db433c3
Compare
|
I believe the test failure is unrelated as described in #277 |
|
|
||
| if [ "$DRA_WORKFLOW" == "staging" ]; then | ||
| MANIFEST_URL=$(curl https://artifacts-"$DRA_WORKFLOW".elastic.co/beats/latest/"$VERSION".json | jq -r '.manifest_url') | ||
| else | ||
| MANIFEST_URL=$(curl https://artifacts-"$DRA_WORKFLOW".elastic.co/beats/latest/"$VERSION"-SNAPSHOT.json | jq -r '.manifest_url') | ||
| fi | ||
|
|
||
| # Retrieve version value | ||
| VERSION=$(curl -s --retry 5 --retry-delay 10 "$MANIFEST_URL" | jq -r '.version') |
There was a problem hiding this comment.
$VERSION is used above, before it's defined
There was a problem hiding this comment.
Good catch. Fixed in af501a4
|
|
||
| ### After a patch release | ||
|
|
||
| Update version in `Directory.Build.props` in the branch for the related minor version (ex: https://github.com/elastic/elastic-stack-installers/pull/183). |
There was a problem hiding this comment.
Maybe Directory.Build.props should have a place-holder version like 0.0.0 to avoid confusion ?
There was a problem hiding this comment.
Maybe
Directory.Build.propsshould have a place-holder version like0.0.0to avoid confusion ?
Not sure I follow, in this PR we are completely removing the file Directory.Build.props as it doesn't seem to be needed anywhere. Additionally all references to manual tasks in the README file.
Do you think we still need to keep the file?
There was a problem hiding this comment.
We're all good, my bad. I was looking for a change that removes the property not the entire file, I didn't realise it only holds this one value.
|
The latest CI test failures are related to #277 |
To facilitate testing, we relax the conditionals that control the pipeline execution. This commit will be reverted before merging.
dliappis
force-pushed
the
honor-version-from-stack-url
branch
from
de857fc to
7662c03
Compare
Now that we rely on MANIFEST_URL for the $VERSION, we don't need to have logic whether it contains a -SNAPSHOT suffix; it's already correctly defined in the manifest.
in order to test packaging from PRs, we honor an optional DRA_BRANCH env var
This reverts commit d50acd2.
This reverts commit f3bc775.
This reverts commit 7662c03.
|
A test simulating the way that unified release triggers this job has been successful: https://buildkite.com/elastic/elastic-stack-installers/builds/5498#019054b1-ae75-47ae-96df-df84aa5b7f20 I have now reverted 7662c03 and f3bc775 which was raised to help running the build in the same way as the unified release does. @alpar-t do you mind taking another look? the only change since you LGTMed it last time is one bug fix: |
|
Backported to 8.14: #280 |
This commit derives the version directly from the MANIFEST_URL env var rather than rely on `StackVersion` defined in `Directory.Build.Props`. Closes #271
This commit derives the version directly from the MANIFEST_URL env var rather than rely on
StackVersiondefined inDirectory.Build.Props.Closes #271