Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow independent-agent-release-staging for dra staging workflow #281

Closed
wants to merge 8 commits into from

Conversation

gogochan
Copy link

@gogochan gogochan commented Jun 26, 2024

This PR allows independent-agent-release-staging to trigger Stack installers Staging workflow.

Independent Agent Release needs to include Windows installer. Our intent is to only include Agent binary.

@gogochan gogochan requested a review from a team as a code owner June 26, 2024 16:44
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also adjust the conditional in

elseif (-not (Test-Path env:MANIFEST_URL) -and ($env:BUILDKITE_SOURCE -ne "trigger_job") -and ($env:BUILDKITE_TRIGGERED_FROM_BUILD_PIPELINE_SLUG -notlike "unified-release*")) {
to also exclude independent-agent-release-staging

@gogochan gogochan requested a review from a team as a code owner July 8, 2024 19:10
@amitkanfer
Copy link
Contributor

build failed, but seems unrelated to the recent changes?

@gogochan
Copy link
Author

gogochan commented Jul 8, 2024

Yeah, this seems to be unrelated. I've posted a question in #282 (comment)

With elastic agent early releases we have a version scheme like
8.14.0+build202407021002 . This commit adjusts the existing filter
for VERSION such that it can also trim +.* suffixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants