Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError: elasticsearch_dsl.aggs.A() got multiple values for keyword argument 'filter' #1902

Closed
rikkt0r opened this issue Sep 6, 2024 · 1 comment
Closed

TypeError: elasticsearch_dsl.aggs.A() got multiple values for keyword argument 'filter' #1902

rikkt0r opened this issue Sep 6, 2024 · 1 comment

Comments

@rikkt0r
Copy link
Contributor

rikkt0r commented Sep 6, 2024

Error occures when accessing bucket aggregation containing a filter directly from AggBase derivate instead of .aggs dict.

The cause of this is the "filter" kwarg passed excessively, colliding with related aggregation params

Minimal sample to reproduce:

b = aggs.Filter(query.Terms(something=[1, 2, 3]))

a = aggs.Terms(field="some_field", size=100)
a.bucket("b", b)

a.aggs['b']  # Ok !
a['b']  # TypeError: elasticsearch_dsl.aggs.A() got multiple values for keyword argument 'filter'
@rikkt0r rikkt0r mentioned this issue Sep 6, 2024
Merged
miguelgrinberg pushed a commit that referenced this issue Sep 11, 2024
@rikkt0r
Removed unnecessary filter argument in AggBase.__getitem__ (#1903)
b06a222 
* Remove excessive filter kwarg appearing in AggBase direct aggregation access (#1902)

* Typo (#1902)
github-actions bot pushed a commit that referenced this issue Sep 11, 2024
@rikkt0r @github-actions
Removed unnecessary filter argument in AggBase.__getitem__ (#1903)
b4d5cef 
* Remove excessive filter kwarg appearing in AggBase direct aggregation access (#1902)

* Typo (#1902)

(cherry picked from commit b06a222)
miguelgrinberg pushed a commit that referenced this issue Sep 11, 2024
@github-actions @rikkt0r
Removed unnecessary filter argument in AggBase.__getitem__ (#1903) (
afd340b 
#1906)

* Remove excessive filter kwarg appearing in AggBase direct aggregation access (#1902)

* Typo (#1902)

(cherry picked from commit b06a222)

Co-authored-by: Grzegorz Wójcicki <[email protected]>
@rikkt0r
Copy link
Contributor Author

rikkt0r commented Sep 12, 2024

I'm closing this issue. The patch will arrive in the upcoming 8.15.3 release

@rikkt0r rikkt0r closed this as completed Sep 12, 2024
miguelgrinberg pushed a commit to miguelgrinberg/elasticsearch-dsl-py that referenced this issue Dec 9, 2024
@rikkt0r @miguelgrinberg
Removed unnecessary filter argument in AggBase.__getitem__ (elast…
6ce152f 
…ic#1903)

* Remove excessive filter kwarg appearing in AggBase direct aggregation access (elastic#1902)

* Typo (elastic#1902)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rikkt0r