Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CombinedFields query #1557

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Add CombinedFields query #1557

merged 1 commit into from
Jan 19, 2022

Conversation

Telomeraz
Copy link
Contributor

Closes #1556

@vipulg13 vipulg13 mentioned this pull request Jan 18, 2022
Closed
sethmlarson
sethmlarson approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Can you sign the CLA?

@sethmlarson sethmlarson reopened this Jan 18, 2022
@sethmlarson sethmlarson mentioned this pull request Jan 18, 2022
Closed
@Telomeraz
Copy link
Contributor Author

Thanks for this! Can you sign the CLA?

@sethmlarson I signed it already.

@sethmlarson
Copy link
Contributor

@Telomeraz Awesome, it just hadn't refreshed on the commit status. Thanks!

@sethmlarson sethmlarson merged commit e865d8a into elastic:master Jan 19, 2022
@lukejs97
Copy link

Am I correct that this change does not exist in the latest release? Looks like this was merged to master on 1/19/22 but the the last release was on 7/15/21. If so, is there a way to use combined_fields before the next release?

@vipulg13
Copy link

that's true! it seems that the intermediate release has been deleted.
I had this feature after upgrading the package sometime in January. Today, I accidentally upgraded the package and found that the feature is no more supported. @sethmlarson @Telomeraz could you please look into this issue?

@vipulg13
Copy link

I happened to check my old installation script and found that I installed this package via git with the then current master branch. Probably, there is no official release after v7.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for "combined_fields" query
4 participants
@Telomeraz @sethmlarson @lukejs97 @vipulg13