Remove support for Python 3.7 #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pquentin
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Thanks! LGTM. I thought this would be more involved than that.
Can you please run pip install pyupgrade && pyupgrade --py38-plus **/*.py? This will update build-dist.py to use shlex.join (new in Python 3.8) and python -m build (as invoking setup.py is deprecated).
You also need to change py37 to py38 in noxfile.py (and make sure to do it in utils/run-unasync.py in the async PR). Not that it makes any difference.
Also, yay, we can now use the walrus operator, positional-only parameters and use = in f-strings! https://docs.python.org/3/whatsnew/3.8.html
Closed
miguelgrinberg
force-pushed
the
remove-py37
branch
from
774a5aa to
0abdc88
Compare
miguelgrinberg
added a commit
to miguelgrinberg/elasticsearch-dsl-py
that referenced
this pull request
Apr 3, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 3, 2024
(cherry picked from commit ab1421a)
miguelgrinberg
added a commit
that referenced
this pull request
Apr 3, 2024
(cherry picked from commit ab1421a) Co-authored-by: Miguel Grinberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, we are removing Python 3.7 from the actively supported versions.