Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation fixes #1769

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Documentation fixes #1769

merged 1 commit into from
Apr 8, 2024

Conversation

miguelgrinberg
Copy link
Collaborator

I noticed a few minor issues:

  • A couple of broken links to low-level client's documentation pages
  • Missing inherited members in API reference pages (regression introduced with 8.13, it was fine in <=8.12)
  • A few Sphinx docstring fixes

@miguelgrinberg miguelgrinberg requested a review from pquentin April 5, 2024 18:27
pquentin
pquentin approved these changes Apr 6, 2024
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@miguelgrinberg miguelgrinberg merged commit cdb14b6 into elastic:main Apr 8, 2024
15 checks passed
@miguelgrinberg miguelgrinberg deleted the various-documentation-fixes branch April 8, 2024 08:34
@miguelgrinberg miguelgrinberg added the backport 8.x Backport to 8.x label Apr 29, 2024
github-actions bot pushed a commit that referenced this pull request Apr 29, 2024
@miguelgrinberg @github-actions
Documentation fixes (#1769)
7dd3a6b 
(cherry picked from commit cdb14b6)
@github-actions github-actions bot mentioned this pull request Apr 29, 2024
Merged
miguelgrinberg added a commit that referenced this pull request Apr 29, 2024
@miguelgrinberg
Documentation fixes (#1769)
c5b069a 
(cherry picked from commit cdb14b6)
miguelgrinberg added a commit that referenced this pull request Apr 29, 2024
@github-actions @miguelgrinberg
Documentation fixes (#1769) (#1789)
891c2fe 
(cherry picked from commit cdb14b6)

Co-authored-by: Miguel Grinberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

Assignees
No one assigned
Labels
backport 8.x Backport to 8.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miguelgrinberg @pquentin