Added support for slicing multiple times in Search class #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pquentin
reviewed
Apr 10, 2024
pquentin
reviewed
Apr 10, 2024
|
@pquentin I have simplified the slicing even more. If the from or the size aren't specified in the slicing, then they are not included in the final request body. So for example:
|
pquentin
reviewed
Apr 11, 2024
There was a problem hiding this comment.
Thanks! The logic looks good. It just needs documentation.
My only remaining worry is that this is a breaking change. Would it be useful to warn about using multiple slices in 8.13.1 and 8.14 and then switch to the new behavior in 8.15? Some users do pay attention to our warnings: elastic/elasticsearch-py#2518 (comment).
pquentin
reviewed
Apr 12, 2024
pquentin
approved these changes
Apr 12, 2024
miguelgrinberg
force-pushed
the
multi-slicing
branch
from
0074785 to
863f033
Compare
github-actions bot
pushed a commit
that referenced
this pull request
May 16, 2024
* Added support for slicing multiple times in Search class Fixes #799 * simplify slicing logic * A few more slicing unit tests * Removed unnecessary comment * simplified slicing logic even more * added suggested changes * add more slicing examples to documentation (cherry picked from commit fb57759)
pquentin
pushed a commit
that referenced
this pull request
May 17, 2024
* Added support for slicing multiple times in Search class Fixes #799 * simplify slicing logic * A few more slicing unit tests * Removed unnecessary comment * simplified slicing logic even more * added suggested changes * add more slicing examples to documentation (cherry picked from commit fb57759) Co-authored-by: Miguel Grinberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #799
This PR implements Pythonic slicing for the
Searchobject.Note: due to introducing backward incompatibilities, this change is scheduled to be incorporated in release 8.15. Starting with release 8.13.1 a warning will alert developers slicing results multiple times that this breaking change is coming.