Add index creation to aggregations example #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelgrinberg
force-pushed
the
agg-example-create-index
branch
from
c7cf87c to
0d49272
Compare
pquentin
approved these changes
Jul 9, 2024
tests/test_integration/test_data.py
Outdated
Comment on lines
61
to
63
| # just one shard, no replicas for testing | ||
| "number_of_shards": 1, | ||
| "number_of_replicas": 0, |
There was a problem hiding this comment.
So I know this was already here, but this seems pointless. After all examples are here to share good practices. And I would be surprised if this resulted in significant savings.
There was a problem hiding this comment.
Yes, I agree, I'll remove it.
miguelgrinberg
force-pushed
the
agg-example-create-index
branch
from
e3914bb to
9dda757
Compare
pquentin
approved these changes
Jul 10, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
* Add index creation to aggregations example * remove shard/replica restrictions from test datasets (cherry picked from commit 8a110b0)
miguelgrinberg
added a commit
that referenced
this pull request
Jul 10, 2024
* Add index creation to aggregations example * remove shard/replica restrictions from test datasets (cherry picked from commit 8a110b0) Co-authored-by: Miguel Grinberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aggregations example (composite_agg.py) assumes an index called
githas been created and populated in advance, which in practice makes it impossible for most people to get the example to run.The git index is one of the datasets used by the integration tests. In this change I have added the logic to create and populate the index, so that the example can be standalone like all the other examples.