-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for bulk document operations #1864
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelgrinberg
force-pushed
the
bulk-support
branch
2 times, most recently
from
July 10, 2024 16:01
8c5b1f0
to
e06f0a8
Compare
miguelgrinberg
force-pushed
the
bulk-support
branch
from
July 20, 2024 11:14
e06f0a8
to
5a01221
Compare
pquentin
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
Co-authored-by: Quentin Pradet <[email protected]>
miguelgrinberg
force-pushed
the
bulk-support
branch
from
July 30, 2024 13:02
d8024d9
to
8453006
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
* Add support for bulk document operations * Apply suggestions from code review Co-authored-by: Quentin Pradet <[email protected]> --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit d81786c)
miguelgrinberg
added a commit
that referenced
this pull request
Jul 30, 2024
* Add support for bulk document operations * Apply suggestions from code review Co-authored-by: Quentin Pradet <[email protected]> --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit d81786c) Co-authored-by: Miguel Grinberg <[email protected]>
miguelgrinberg
added a commit
to miguelgrinberg/elasticsearch-dsl-py
that referenced
this pull request
Dec 9, 2024
* Add support for bulk document operations * Apply suggestions from code review Co-authored-by: Quentin Pradet <[email protected]> --------- Co-authored-by: Quentin Pradet <[email protected]>
miguelgrinberg
added a commit
to miguelgrinberg/elasticsearch-dsl-py
that referenced
this pull request
Dec 9, 2024
* Add support for bulk document operations * Apply suggestions from code review Co-authored-by: Quentin Pradet <[email protected]> --------- Co-authored-by: Quentin Pradet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds
Document.bulk
andAsyncDocument.bulk
. These work similarly to the bulk helper in the low-level client, but the provided generator must return document instances, and the document'sclean()
method is called before adding to the bulk request.