-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement distance_feature query #3983
Conversation
Needs a skipversion attribute, integration tests fail on order versions due to:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments about the property types of "pivot"
and "origin"
src/Nest/QueryDsl/Specialized/DistanceFeature/DistanceFeatureQuery.cs
Outdated
Show resolved
Hide resolved
src/Nest/QueryDsl/Specialized/DistanceFeature/DistanceFeatureQuery.cs
Outdated
Show resolved
Hide resolved
- Change properties from string to Union<T1, T2> - Add Skipversion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but left some small comments. Might be useful to make some assertions on the response in the integration test, but may need to make the pivot larger, such as 180d
src/Nest/QueryDsl/Specialized/DistanceFeature/DistanceFeatureQuery.cs
Outdated
Show resolved
Hide resolved
src/Nest/QueryDsl/Specialized/DistanceFeature/DistanceFeatureQuery.cs
Outdated
Show resolved
Hide resolved
src/Tests/Tests/QueryDsl/Specialized/DistanceFeature/DistanceFeatureQueryUsageTests.cs
Outdated
Show resolved
Hide resolved
…uery.cs Co-Authored-By: Russ Cam <[email protected]>
…uery.cs Co-Authored-By: Russ Cam <[email protected]>
…uery.cs Co-Authored-By: Russ Cam <[email protected]>
Implement distance_feature query
Implement distance_feature query (cherry picked from commit e58db5b)
Implements https://www.elastic.co/guide/en/elasticsearch/reference/7.x/query-dsl-distance-feature-query.html