Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce the columnar option for SQL REST requests. #3984

Merged
merged 2 commits into from
Aug 9, 2019
Merged

Introduce the columnar option for SQL REST requests. #3984

merged 2 commits into from
Aug 9, 2019

Conversation

codebrain
Copy link
Contributor

@codebrain codebrain mentioned this pull request Aug 2, 2019
Closed
37 tasks
@Mpdreamz
Copy link
Member

Mpdreamz commented Aug 2, 2019 

Failed   Tests.CodeStandards.Descriptors.NullableBooleansShouldDefaultToTrue
Error Message:
 Expected collection to be empty, but found {"bool columnar on method Columnar of Nest.QuerySqlDescriptor is has no default value", "bool columnar on method Columnar of Nest.QuerySqlDescriptor defaults to unknown"}.

russcam
russcam suggested changes Aug 7, 2019
View reviewed changes
Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion

src/Nest/XPack/Sql/QuerySql/QuerySqlRequest.cs Outdated Show resolved Hide resolved
@codebrain codebrain merged commit 493bb45 into 7.2 Aug 9, 2019
codebrain added a commit that referenced this pull request Aug 16, 2019
@codebrain
Introduce the columnar option for SQL REST requests. (#3984)
39ad9a2 
Implements elastic/elasticsearch#39287
@russcam russcam deleted the feature/7.2/sql-columnar branch September 1, 2019 22:41
russcam pushed a commit that referenced this pull request Sep 3, 2019
@codebrain @russcam
Introduce the columnar option for SQL REST requests. (#3984)
b779cb3 
Implements elastic/elasticsearch#39287

(cherry picked from commit 39ad9a2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russcam russcam russcam requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebrain @Mpdreamz @russcam