Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API generator #4456

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Fix API generator #4456

merged 1 commit into from
Feb 25, 2020

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Feb 25, 2020

This commit fixes the API generator and removes REST API specs
ported from later version branches:

  1. The collection of high level endpoints were being used in some
    of the low level generators
  2. High level endpoints excluded need to be compared to the list by filename
  3. Exclude new ML experimental APIs

@codebrain
Copy link
Contributor

Co-authored over Zoom, LGTM

This commit fixes the API generator and removes REST API specs
ported from later version branches:

1. The collection of high level endpoints were being used in some
of the low level generators
2. High level endpoints excluded need to be compared to the list by filename
3. Exclude new ML experimental APIs

Co-authored-by: Stuart Cam <[email protected]>
@russcam russcam force-pushed the fix/7.6/api-generator branch from a82fc66 to f5f793a Compare February 25, 2020 05:02
@russcam russcam merged commit 04ed38b into 7.6 Feb 25, 2020
@russcam russcam deleted the fix/7.6/api-generator branch February 25, 2020 05:03
russcam added a commit that referenced this pull request Mar 27, 2020
This commit fixes the API generator:

1. The collection of high level endpoints were being used in some
of the low level generators
2. High level endpoints excluded need to be compared to the list by filename

Co-authored-by: Stuart Cam <[email protected]>

(cherry-picked from commit 04ed38b)
russcam added a commit that referenced this pull request Mar 27, 2020
This commit fixes the API generator:

1. The collection of high level endpoints were being used in some
of the low level generators
2. High level endpoints excluded need to be compared to the list by filename

Co-authored-by: Stuart Cam <[email protected]>

(cherry-picked from commit 04ed38b)
github-actions bot pushed a commit that referenced this pull request Mar 27, 2020
This commit fixes the API generator:

1. The collection of high level endpoints were being used in some
of the low level generators
2. High level endpoints excluded need to be compared to the list by filename

Co-authored-by: Stuart Cam <[email protected]>

(cherry-picked from commit 04ed38b)
github-actions bot pushed a commit that referenced this pull request Mar 27, 2020
This commit fixes the API generator:

1. The collection of high level endpoints were being used in some
of the low level generators
2. High level endpoints excluded need to be compared to the list by filename

Co-authored-by: Stuart Cam <[email protected]>

(cherry-picked from commit 04ed38b)
russcam added a commit that referenced this pull request Mar 27, 2020
This commit fixes the API generator:

1. The collection of high level endpoints were being used in some
of the low level generators
2. High level endpoints excluded need to be compared to the list by filename

Co-authored-by: Stuart Cam <[email protected]>

(cherry-picked from commit 04ed38b)

Co-authored-by: Russ Cam <[email protected]>
codebrain pushed a commit that referenced this pull request Mar 27, 2020
This commit fixes the API generator:

1. The collection of high level endpoints were being used in some
of the low level generators
2. High level endpoints excluded need to be compared to the list by filename

Co-authored-by: Stuart Cam <[email protected]>

(cherry-picked from commit 04ed38b)

Co-authored-by: Russ Cam <[email protected]>
(cherry picked from commit 145869b)
russcam pushed a commit that referenced this pull request Mar 30, 2020
This commit fixes the API generator:

1. The collection of high level endpoints were being used in some
of the low level generators
2. High level endpoints excluded need to be compared to the list by filename

Co-authored-by: Stuart Cam <[email protected]>
Co-authored-by: Russ Cam <[email protected]>

(cherry-picked from commit 04ed38b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants