Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script_cache to Node Stats API #4744

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Jun 9, 2020

Relates: #4718

This commit adds the script_cache to node stats
API response.

Relates: #4718

This commit adds the script_cache to node stats
API response.
@@ -85,6 +92,9 @@ public class ScriptStats

[DataMember(Name = "compilations")]
public long Compilations { get; internal set; }

[DataMember(Name = "compilation_limit_triggered")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just double checking this always comes back as 0 from the server?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value returned is always 0? Might be tricky to have a valid greater than 0 returned in tests.

The server side defines the property here

https://github.com/elastic/elasticsearch/blob/32f46f2214808c0b2c2271bf977f2f08fe6d6fbc/server/src/main/java/org/elasticsearch/script/ScriptCacheStats.java#L108

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russcam russcam merged commit 15f401a into master Jun 10, 2020
@russcam russcam deleted the feature/script-cache-node-stats branch June 10, 2020 02:49
github-actions bot pushed a commit that referenced this pull request Jun 10, 2020
Relates: #4718

This commit adds the script_cache to node stats API response.
github-actions bot pushed a commit that referenced this pull request Jun 10, 2020
Relates: #4718

This commit adds the script_cache to node stats API response.
russcam added a commit that referenced this pull request Jun 10, 2020
Relates: #4718

This commit adds the script_cache to node stats API response.

Co-authored-by: Russ Cam <[email protected]>
russcam added a commit that referenced this pull request Jun 10, 2020
Relates: #4718

This commit adds the script_cache to node stats API response.

Co-authored-by: Russ Cam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants