-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script_cache to Node Stats API #4744
Conversation
Relates: #4718 This commit adds the script_cache to node stats API response.
@@ -85,6 +92,9 @@ public class ScriptStats | |||
|
|||
[DataMember(Name = "compilations")] | |||
public long Compilations { get; internal set; } | |||
|
|||
[DataMember(Name = "compilation_limit_triggered")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just double checking this always comes back as 0
from the server?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value returned is always 0
? Might be tricky to have a valid greater than 0
returned in tests.
The server side defines the property here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Relates: #4718 This commit adds the script_cache to node stats API response.
Relates: #4718 This commit adds the script_cache to node stats API response.
Relates: #4718 This commit adds the script_cache to node stats API response. Co-authored-by: Russ Cam <[email protected]>
Relates: #4718 This commit adds the script_cache to node stats API response. Co-authored-by: Russ Cam <[email protected]>
Relates: #4718
This commit adds the script_cache to node stats
API response.