-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR] The proj files have been updated to enable SourceLink #4819
Conversation
…icsearch.Net.csproj]
…icsearch.Net.VirtualizedCluster.csproj]
…JsonNetSerializer.csproj]
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Hi @JTOne123, The PDBs are shipped with the nuget packages, and source linking is performed in a This might have come up as a false positive because the automated project is only looking for snupkgs: https://github.com/JTOne123/GitHubMassUpdater/blob/bfa009f9fbd1ec1aa82f02c85239582b018ae63e/GitHubSearch/Program.cs#L144 |
Thought I'd check to see where the embed PDBs vs. snupkgs discussion is, and it looks like snupkgs may still not be support on all Nuget servers (dotnet/sourcelink#255). Since we also publish packages to AppVeyor (and looking at Feedz), embedding PDBs still looks like the way to go for now. |
yes, you are right, only on nuget.org and this is bad but in case of snuget, it will split into 2 files and size will be decreased of original nuget pack so, in your case, I'll close the PR |
CSProj files have been updated to enable SourceLink in your nuget
[This pull request was created with an automated workflow]
I noticed that your repository and Nuget package are important for our .NET community, but you still haven't enabled SourceLink.
We have to take 2 steps:
You can find more information about SourceLine at the following links
https://github.com/dotnet/sourcelink
https://www.hanselman.com/blog/ExploringNETCoresSourceLinkSteppingIntoTheSourceCodeOfNuGetPackagesYouDontOwn.aspx
If you are interesting about this automated workflow and how it works
https://github.com/JTOne123/GitHubMassUpdater
If you notice any flaws, please comment and I will try to make fixes manually