-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support indexing pressure on NodeStats #5148
Conversation
Indexing pressure stats were added in 7.9.0 elastic/elasticsearch#59467 They were updated to include memory limit stats in 7.10.0 elastic/elasticsearch#60342
public MemoryStats Memory { get; internal set; } | ||
|
||
[DataContract] | ||
public class MemoryStats |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I think inner classes are the best choice stylistically once we shift from hand rolling these to generating these it will be hard to know when inner classes are preferred.
I hate saying it but smurf types are better here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a new term for me 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've moved out to non-nested classes @Mpdreamz. If this change is what you expected, hopefully we're good to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left one comment about value type properties might needing to be nullable depending on wheter they are always present or not.
* Support indexing pressure on NodeStats Indexing pressure stats were added in 7.9.0 elastic/elasticsearch#59467 They were updated to include memory limit stats in 7.10.0 elastic/elasticsearch#60342
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-master master
# Navigate to the new working tree
cd .worktrees/backport-master
# Create a new branch
git switch --create backport-5148-to-master
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ---mainline 1 de02c9de8d218a3de8a05d1214c7c8b81fe51697
# Push it to GitHub
git push --set-upstream origin backport-5148-to-master
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-master Then, create a pull request where the |
* Support indexing pressure on NodeStats Indexing pressure stats were added in 7.9.0 elastic/elasticsearch#59467 They were updated to include memory limit stats in 7.10.0 elastic/elasticsearch#60342
* Support indexing pressure on NodeStats Indexing pressure stats were added in 7.9.0 elastic/elasticsearch#59467 They were updated to include memory limit stats in 7.10.0 elastic/elasticsearch#60342
* Support indexing pressure on NodeStats Indexing pressure stats were added in 7.9.0 elastic/elasticsearch#59467 They were updated to include memory limit stats in 7.10.0 elastic/elasticsearch#60342 Co-authored-by: Steve Gordon <[email protected]>
Indexing pressure stats were added in 7.9.0
elastic/elasticsearch#59467
They were updated to include memory limit stats in 7.10.0
elastic/elasticsearch#60342
Contributes to #5096