ClientBuilder: setLogger() and setTracer() only accept \Psr\Log\LoggerInterface #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhujer
force-pushed
the
mh-clientbuilder-typehints
branch
from
33eacbb to
4139825
Compare
mhujer
force-pushed
the
mh-clientbuilder-typehints
branch
from
4139825 to
17cd389
Compare
…rInterface This is a more verbose approach than directly adding typehints, but it won't break the projects which may be extending ClientBuilder.
mhujer
force-pushed
the
mh-clientbuilder-typehints
branch
from
17cd389 to
c9561c8
Compare
|
As always, much ❤️ and apologies for the delay. This other project is crushing my available time :( |
polyfractal
pushed a commit
that referenced
this pull request
Dec 5, 2017
…rInterface (#673) This is a more verbose approach than directly adding typehints, but it won't break the projects which may be extending ClientBuilder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially supersedes #296.
This is a more verbose approach than directly adding typehints, but it
won't break the projects which may be extending ClientBuilder.