Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused Monolog in ClientBuilder #948

Merged
merged 1 commit into from
Sep 2, 2019
Merged

Removed unused Monolog in ClientBuilder #948

merged 1 commit into from
Sep 2, 2019

Conversation

ezimuel
Copy link
Contributor

@ezimuel ezimuel commented Aug 30, 2019

This PR fixes #813 issue, removing unused Monolog classes in ClientBuilder. Even if the use of Monolog is not in invoked in ClientBuilder, this can produce errors if you want to mock the class for testing.

NOTE this PR should also be merged in 6.x and 5.0 branches.

@ezimuel ezimuel requested a review from philkra August 30, 2019 14:32
Copy link
Contributor

@philkra philkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ezimuel ezimuel merged commit 1944225 into elastic:master Sep 2, 2019
ezimuel added a commit that referenced this pull request Sep 2, 2019
ezimuel added a commit that referenced this pull request Sep 2, 2019
ezimuel added a commit that referenced this pull request Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to mock ClientBuilder in unit testing due to Monolog dependency inside
2 participants