Update CI to use cargo make #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces the use of ES_TEST_SERVER with ELASTICSEARCH_URL, for consistency
This commit attempts to simplify the CI test flow by 1. Using rust latest docker image as base image and using a specific rust toolchain 2. Using cargo make to run the testing process
|
I'm having some issues with Docker on Windows WSL2 in testing this change locally - Disk Usage consistently jumps to hover between 50-100% and docker becomes unresponsive at the point of running |
|
Testing on CI looks good: https://clients-ci.elastic.co/job/elastic+elasticsearch-rs+master/88/ |
swallez
reviewed
Sep 3, 2020
This commit updates the Dockerfile used in CI tests to use rust:latest base image and pull the image before building to ensure that latest tag is the latest release. It appears that the -Z unstable-options --format json works on rust stable channel, despite rust documentation to the contrary.
russcam
added a commit
that referenced
this pull request
Sep 3, 2020
This commit simplifies the CI test flow by - Using rust latest docker image as base image - Using cargo make to run the testing process pull the docker image before building to ensure that latest tag is the latest release. It appears that the -Z unstable-options --format json works on rust stable channel, despite rust documentation to the contrary. It also replaces the use of ES_TEST_SERVER with ELASTICSEARCH_URL, for consistency (cherry picked from commit 6c13b1d)
russcam
added a commit
that referenced
this pull request
Sep 3, 2020
This commit simplifies the CI test flow by - Using rust latest docker image as base image - Using cargo make to run the testing process pull the docker image before building to ensure that latest tag is the latest release. It appears that the -Z unstable-options --format json works on rust stable channel, despite rust documentation to the contrary. It also replaces the use of ES_TEST_SERVER with ELASTICSEARCH_URL, for consistency (cherry picked from commit 6c13b1d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the scripts use to run YAML tests on CI to
The use of the
ES_TEST_SERVERenv var is replaced withELASTICSEARCH_URLin all places, for consistency.