Skip to content

Commit

Permalink
[API] Updated the YAML integration test suite runner to support open …
Browse files Browse the repository at this point in the history
…ranges

Due to the change in elastic/elasticsearch@68f75ea, the normalized minimum and maximum versions
no longer matched the assumptions about the version definition in the `skip` statement.

The condition has been updated to check for empty `min` and `max` (non-normalized) versions.

Related: elastic/elasticsearch#10656
  • Loading branch information
karmi committed Apr 21, 2015
1 parent ab452c5 commit d0f792f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion elasticsearch-api/test/integration/yaml_test_runner.rb
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ def skip?(actions)

es_normalized = sprintf "%03d-%03d-%03d", *$es_version.split('.').map(&:to_i)

if min_normalized <= es_normalized && max_normalized >= es_normalized
if ( min.empty? || min_normalized <= es_normalized ) && ( max.empty? || max_normalized >= es_normalized )
return skip['skip']['reason'] ? skip['skip']['reason'] : true
end

Expand Down

0 comments on commit d0f792f

Please sign in to comment.