-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Nodes.Info] Fix NodeInfoPath data #3194
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
pquentin
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
github-actions bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
* change data type from array to union * make contrib (cherry picked from commit b8baaa7)
github-actions bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
* change data type from array to union * make contrib (cherry picked from commit b8baaa7)
github-actions bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
* change data type from array to union * make contrib (cherry picked from commit b8baaa7)
Anaethelion
added a commit
that referenced
this pull request
Dec 3, 2024
* change data type from array to union * make contrib (cherry picked from commit b8baaa7) Co-authored-by: Laurent Saint-Félix <[email protected]>
Anaethelion
added a commit
that referenced
this pull request
Dec 3, 2024
* change data type from array to union * make contrib (cherry picked from commit b8baaa7) Co-authored-by: Laurent Saint-Félix <[email protected]>
Anaethelion
added a commit
that referenced
this pull request
Dec 3, 2024
* change data type from array to union * make contrib (cherry picked from commit b8baaa7) Co-authored-by: Laurent Saint-Félix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in elastic/go-elasticsearch#911
Turns out the
data
key is in fact a union over a string and an array. server code for reference.