Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nodes.Info] Fix NodeInfoPath data #3194

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conversation

Anaethelion
Copy link
Contributor

@Anaethelion Anaethelion commented Nov 27, 2024

Reported in elastic/go-elasticsearch#911

Turns out the data key is in fact a union over a string and an array. server code for reference.

Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
nodes.info 🔴 114/114 1/114

You can validate this API yourself by using the make validate target.

@Anaethelion Anaethelion requested a review from a team November 28, 2024 10:54
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@Anaethelion Anaethelion merged commit b8baaa7 into main Dec 3, 2024
10 checks passed
@Anaethelion Anaethelion deleted the fix_nodexinfopath_data branch December 3, 2024 13:23
github-actions bot pushed a commit that referenced this pull request Dec 3, 2024
* change data type from array to union

* make contrib

(cherry picked from commit b8baaa7)
github-actions bot pushed a commit that referenced this pull request Dec 3, 2024
* change data type from array to union

* make contrib

(cherry picked from commit b8baaa7)
github-actions bot pushed a commit that referenced this pull request Dec 3, 2024
* change data type from array to union

* make contrib

(cherry picked from commit b8baaa7)
Anaethelion added a commit that referenced this pull request Dec 3, 2024
* change data type from array to union

* make contrib

(cherry picked from commit b8baaa7)

Co-authored-by: Laurent Saint-Félix <[email protected]>
Anaethelion added a commit that referenced this pull request Dec 3, 2024
* change data type from array to union

* make contrib

(cherry picked from commit b8baaa7)

Co-authored-by: Laurent Saint-Félix <[email protected]>
Anaethelion added a commit that referenced this pull request Dec 3, 2024
* change data type from array to union

* make contrib

(cherry picked from commit b8baaa7)

Co-authored-by: Laurent Saint-Félix <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants