Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inference task type endpoints #3545

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
+1,647 −869
Open

Inference task type endpoints #3545

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
687063f
Refactoring inference endpoints
jonathan-buttner Jan 16, 2025
0442e31
Fixing stream completion url and removing the old url and class
jonathan-buttner Jan 16, 2025
05864d4
generating spec
jonathan-buttner Jan 16, 2025
78ce8a1
Merge branch 'main' of github.com:elastic/elasticsearch-specification…
jonathan-buttner Jan 28, 2025
749c78c
Adding doc id
jonathan-buttner Jan 28, 2025
02219ba
Renaming to match filename
jonathan-buttner Jan 28, 2025
bf22312
Resolving merge conflicts
jonathan-buttner Feb 5, 2025
bd16539
Switching to stream and regenerating files
jonathan-buttner Feb 5, 2025
797d6b5
Using variant and adding _stream
jonathan-buttner Feb 5, 2025
bc1a277
Removing variant
jonathan-buttner Feb 5, 2025
14edb60
Adding chat_completion and fixing update api
jonathan-buttner Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,709 changes: 1,072 additions & 637 deletions output/schema/schema.json
View file
Open in desktop

Large diffs are not rendered by default.

192 changes: 116 additions & 76 deletions output/typescript/types.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

31 changes: 31 additions & 0 deletions specification/_json_spec/inference.chat_completion_inference.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
{
"inference.chat_completion_unified": {
"documentation": {
"url": "https://www.elastic.co/guide/en/elasticsearch/reference/master/chat-completion-inference.html",
"description": "Perform chat completion inference"
},
"stability": "stable",
"visibility": "public",
"headers": {
"accept": ["text/event-stream"],
"content_type": ["application/json"]
},
"url": {
"paths": [
{
"path": "/_inference/chat_completion/{inference_id}/_unified",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be _stream

Suggested change
"path": "/_inference/chat_completion/{inference_id}/_unified",
"path": "/_inference/chat_completion/{inference_id}/_stream",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it does have _unified at the end. I think technically we could remove it since the client code doesn't need the results to be in a specific format for SSE.

"methods": ["POST"],
"parts": {
"inference_id": {
"type": "string",
"description": "The inference Id"
}
}
}
]
},
"body": {
"description": "The inference payload"
}
}
}
20 changes: 3 additions & 17 deletions ...ation/_json_spec/inference.inference.json → ...tion/_json_spec/inference.completion.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"inference.inference": {
"inference.completion": {
"documentation": {
"url": "https://www.elastic.co/guide/en/elasticsearch/reference/master/post-inference-api.html",
"description": "Perform inference"
"description": "Perform completion inference"
},
"stability": "stable",
"visibility": "public",
Expand All @@ -13,28 +13,14 @@
"url": {
"paths": [
{
"path": "/_inference/{inference_id}",
"path": "/_inference/completion/{inference_id}",
"methods": ["POST"],
"parts": {
"inference_id": {
"type": "string",
"description": "The inference Id"
}
}
},
{
"path": "/_inference/{task_type}/{inference_id}",
"methods": ["POST"],
"parts": {
"task_type": {
"type": "string",
"description": "The task type"
},
"inference_id": {
"type": "string",
"description": "The inference Id"
}
}
}
]
},
Expand Down
31 changes: 31 additions & 0 deletions specification/_json_spec/inference.rerank.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
{
"inference.rerank": {
"documentation": {
"url": "https://www.elastic.co/guide/en/elasticsearch/reference/master/post-inference-api.html",
"description": "Perform reranking inference"
},
"stability": "stable",
"visibility": "public",
"headers": {
"accept": ["application/json"],
"content_type": ["application/json"]
},
"url": {
"paths": [
{
"path": "/_inference/rerank/{inference_id}",
"methods": ["POST"],
"parts": {
"inference_id": {
"type": "string",
"description": "The inference Id"
}
}
}
]
},
"body": {
"description": "The inference payload"
}
}
}
Loading
Loading