Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune OpenAPI linters #3704

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Tune OpenAPI linters #3704

merged 2 commits into from
Feb 6, 2025

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Feb 4, 2025

This PR switches the linter that is used to check the OpenAPI files to match what we're using in the Kibana repo.
It also turns off some lint checks that were generating noise and fixes two examples that were generating errors.

@lcawl lcawl marked this pull request as ready for review February 4, 2025 23:37
@lcawl lcawl requested review from a team as code owners February 4, 2025 23:37
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ccr.forget_follower Missing test Missing test
ml.delete_model_snapshot 🟢 2/2 2/2

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lcawl lcawl merged commit d1b88af into main Feb 6, 2025
10 checks passed
@lcawl lcawl deleted the linters branch February 6, 2025 17:25
Copy link
Contributor

github-actions bot commented Feb 6, 2025

The backport to 8.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-3704-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d1b88afba8ff22e761dd74d4dbccf4382bf3ca25
# Push it to GitHub
git push --set-upstream origin backport-3704-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x

Then, create a pull request where the base branch is 8.x and the compare/head branch is backport-3704-to-8.x.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

The backport to 8.18 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-3704-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d1b88afba8ff22e761dd74d4dbccf4382bf3ca25
# Push it to GitHub
git push --set-upstream origin backport-3704-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18

Then, create a pull request where the base branch is 8.18 and the compare/head branch is backport-3704-to-8.18.

github-actions bot pushed a commit that referenced this pull request Feb 6, 2025
(cherry picked from commit d1b88af)
lcawl added a commit that referenced this pull request Feb 6, 2025
(cherry picked from commit d1b88af)

Co-authored-by: Lisa Cawley <[email protected]>
lcawl added a commit that referenced this pull request Feb 6, 2025
(cherry picked from commit d1b88af)
@lcawl
Copy link
Contributor Author

lcawl commented Feb 6, 2025

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit that referenced this pull request Feb 6, 2025
(cherry picked from commit d1b88af)
@lcawl
Copy link
Contributor Author

lcawl commented Feb 6, 2025

💚 All backports created successfully

Status Branch Result
8.18

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit that referenced this pull request Feb 6, 2025
(cherry picked from commit d1b88af)
@lcawl
Copy link
Contributor Author

lcawl commented Feb 6, 2025

💚 All backports created successfully

Status Branch Result
8.17

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit that referenced this pull request Feb 6, 2025
(cherry picked from commit d1b88af)
lcawl added a commit that referenced this pull request Feb 6, 2025
(cherry picked from commit d1b88af)
lcawl added a commit that referenced this pull request Feb 6, 2025
(cherry picked from commit d1b88af)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants