Skip to content

Commit

Permalink
Timeout on buildkite artifact upload but do not fail the build (#114430)
Browse files Browse the repository at this point in the history
this workarounds an issue we currently see on windows ci boxes where we
run into timeouts in this step in our builds
  • Loading branch information
breskeby authored Oct 9, 2024
1 parent d29f7a1 commit 0736bf5
Showing 1 changed file with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,13 @@ public void execute(BuildFinishedFlowAction.Parameters parameters) throws FileNo
// So, if you change this such that the artifact will have a slash/directory in it, you'll need to update the logic
// below as well
pb.directory(uploadFileDir);
pb.start().waitFor();
try {
// we are very generious here, as the upload can take
// a long time depending on its size
pb.start().waitFor(30, java.util.concurrent.TimeUnit.MINUTES);
} catch (InterruptedException e) {
System.out.println("Failed to upload buildkite artifact " + e.getMessage());
}

System.out.println("Generating buildscan link for artifact...");

Expand Down

0 comments on commit 0736bf5

Please sign in to comment.