Add unit tests for NestedAggregator (#24054)

Add unit tests for NestedAggregator, change class visibilities Relates to #22278
elastic · Apr 12, 2017 · 1fd50bc · 1fd50bc
1 parent e99f90f
commit 1fd50bc
Show file tree

Hide file tree

Showing 4 changed files with 302 additions and 105 deletions.
diff --git a/core/src/main/java/org/elasticsearch/search/aggregations/bucket/nested/InternalNested.java b/core/src/main/java/org/elasticsearch/search/aggregations/bucket/nested/InternalNested.java
@@ -31,7 +31,7 @@
  * Result of the {@link NestedAggregator}.
  */
 public class InternalNested extends InternalSingleBucketAggregation implements Nested {
-    public InternalNested(String name, long docCount, InternalAggregations aggregations, List<PipelineAggregator> pipelineAggregators,
+    InternalNested(String name, long docCount, InternalAggregations aggregations, List<PipelineAggregator> pipelineAggregators,
             Map<String, Object> metaData) {
         super(name, docCount, aggregations, pipelineAggregators, metaData);
     }

diff --git a/core/src/main/java/org/elasticsearch/search/aggregations/bucket/nested/NestedAggregator.java b/core/src/main/java/org/elasticsearch/search/aggregations/bucket/nested/NestedAggregator.java
@@ -44,14 +44,14 @@
 import java.util.List;
 import java.util.Map;
 
-public class NestedAggregator extends SingleBucketAggregator {
+class NestedAggregator extends SingleBucketAggregator {
 
     static final ParseField PATH_FIELD = new ParseField("path");
 
     private final BitSetProducer parentFilter;
     private final Query childFilter;
 
-    public NestedAggregator(String name, AggregatorFactories factories, ObjectMapper parentObjectMapper, ObjectMapper childObjectMapper,
+    NestedAggregator(String name, AggregatorFactories factories, ObjectMapper parentObjectMapper, ObjectMapper childObjectMapper,
             SearchContext context, Aggregator parentAggregator,
                             List<PipelineAggregator> pipelineAggregators, Map<String, Object> metaData) throws IOException {
         super(name, factories, context, parentAggregator, pipelineAggregators, metaData);

diff --git a/...ain/java/org/elasticsearch/search/aggregations/bucket/nested/NestedAggregatorFactory.java b/...ain/java/org/elasticsearch/search/aggregations/bucket/nested/NestedAggregatorFactory.java
@@ -32,12 +32,12 @@
 import java.util.List;
 import java.util.Map;
 
-public class NestedAggregatorFactory extends AggregatorFactory<NestedAggregatorFactory> {
+class NestedAggregatorFactory extends AggregatorFactory<NestedAggregatorFactory> {
 
     private final ObjectMapper parentObjectMapper;
     private final ObjectMapper childObjectMapper;
 
-    public NestedAggregatorFactory(String name, ObjectMapper parentObjectMapper, ObjectMapper childObjectMapper,
+    NestedAggregatorFactory(String name, ObjectMapper parentObjectMapper, ObjectMapper childObjectMapper,
             SearchContext context, AggregatorFactory<?> parent, AggregatorFactories.Builder subFactories,
                                    Map<String, Object> metaData) throws IOException {
         super(name, context, parent, subFactories, metaData);