Accept the same boolean values in RestRequest

Added `no` as a possible value to `paramBooleanAsOptional`, also reused existing code from `Booleans.parseBoolean` Closes #4808
elastic · Jan 20, 2014 · 32428bf · 32428bf
1 parent 7129b9e
commit 32428bf
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/src/main/java/org/elasticsearch/rest/RestRequest.java b/src/main/java/org/elasticsearch/rest/RestRequest.java
@@ -136,11 +136,7 @@ public boolean paramAsBoolean(String key, boolean defaultValue) {
 
     @Override
     public Boolean paramAsBooleanOptional(String key, Boolean defaultValue) {
-        String sValue = param(key);
-        if (sValue == null) {
-            return defaultValue;
-        }
-        return !(sValue.equals("false") || sValue.equals("0") || sValue.equals("off"));
+        return Booleans.parseBoolean(param(key), defaultValue);
     }
 
     public TimeValue paramAsTime(String key, TimeValue defaultValue) {