move assertion

elastic · Oct 16, 2018 · 6589027 · 6589027
1 parent f196a2a
commit 6589027
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/server/src/test/java/org/elasticsearch/cluster/coordination/CoordinatorTests.java b/server/src/test/java/org/elasticsearch/cluster/coordination/CoordinatorTests.java
@@ -842,14 +842,15 @@ ClusterNode getAnyNode() {
         }
 
         ClusterNode getAnyNodeExcept(ClusterNode... clusterNodes) {
-            return randomFrom(getAllNodesExcept(clusterNodes));
+            List<ClusterNode> filteredNodes = getAllNodesExcept(clusterNodes);
+            assert filteredNodes.isEmpty() == false;
+            return randomFrom(filteredNodes);
         }
 
         List<ClusterNode> getAllNodesExcept(ClusterNode... clusterNodes) {
             Set<String> forbiddenIds = Arrays.stream(clusterNodes).map(ClusterNode::getId).collect(Collectors.toSet());
             List<ClusterNode> acceptableNodes
                 = this.clusterNodes.stream().filter(n -> forbiddenIds.contains(n.getId()) == false).collect(Collectors.toList());
-            assert acceptableNodes.isEmpty() == false;
             return acceptableNodes;
         }