Skip to content

Commit

Permalink
add test for running certain ILM actions during snapshotting
Browse files Browse the repository at this point in the history
  • Loading branch information
@talevy
talevy committed Jan 17, 2019
1 parent ecf0de3 commit 7aeec21
Show file tree
Hide file tree
Showing 2 changed files with 138 additions and 1 deletion.
6 changes: 5 additions & 1 deletion x-pack/plugin/ilm/qa/multi-node/build.gradle
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ dependencies {
testCompile project(path: xpackProject('plugin').path, configuration: 'testArtifacts')
}

integTestRunner {
/* To support taking index snapshots, we have to set path.repo setting */
systemProperty 'tests.path.repo', new File(buildDir, "cluster/shared/repo")
}

integTestCluster {
numNodes = 4
clusterName = 'ilm'
Expand All @@ -16,5 +21,4 @@ integTestCluster {
setting 'xpack.ml.enabled', 'false'
setting 'xpack.license.self_generated.type', 'trial'
setting 'indices.lifecycle.poll_interval', '1000ms'

}
133 changes: 133 additions & 0 deletions ...de/src/test/java/org/elasticsearch/xpack/indexlifecycle/TimeSeriesLifecycleActionsIT.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import org.elasticsearch.common.xcontent.XContentBuilder;
import org.elasticsearch.common.xcontent.XContentHelper;
import org.elasticsearch.common.xcontent.XContentType;
import org.elasticsearch.common.xcontent.json.JsonXContent;
import org.elasticsearch.index.IndexSettings;
import org.elasticsearch.index.engine.FrozenEngine;
import org.elasticsearch.test.rest.ESRestTestCase;
Expand Down Expand Up @@ -58,6 +59,7 @@
import static org.hamcrest.Matchers.equalTo;
import static org.hamcrest.Matchers.greaterThan;
import static org.hamcrest.Matchers.not;
import static org.hamcrest.Matchers.startsWith;

public class TimeSeriesLifecycleActionsIT extends ESRestTestCase {
private String index;
Expand Down Expand Up @@ -357,6 +359,46 @@ public void testDeleteOnlyShouldNotMakeIndexReadonly() throws Exception {
indexDocument();
}

public void testDeleteDuringSnapshot() throws Exception {
// Create the repository before taking the snapshot.
Request request = new Request("PUT", "/_snapshot/repo");
request.setJsonEntity(Strings
.toString(JsonXContent.contentBuilder()
.startObject()
.field("type", "fs")
.startObject("settings")
.field("compress", randomBoolean())
.field("location", System.getProperty("tests.path.repo"))
.field("max_snapshot_bytes_per_sec", "256b")
.endObject()
.endObject()));
assertOK(client().performRequest(request));
// create delete policy
createNewSingletonPolicy("delete", new DeleteAction(), TimeValue.timeValueMillis(0));
// create index without policy
createIndexWithSettings(index, Settings.builder().put(IndexMetaData.SETTING_NUMBER_OF_SHARDS, 1)
.put(IndexMetaData.SETTING_NUMBER_OF_REPLICAS, 0));
// index document so snapshot actually does something
indexDocument();
// start snapshot
request = new Request("PUT", "/_snapshot/repo/snapshot");
request.addParameter("wait_for_completion", "false");
request.setJsonEntity("{\"indices\": \"" + index + "\"}");
assertOK(client().performRequest(request));
// add policy and expect it to trigger delete immediately (while snapshot in progress)
updatePolicy(index, policy);
// assert that exception was thrown
assertBusy(() -> {
assertThat(getStepKeyForIndex(index).getName(), equalTo("ERROR"));
assertThat(getReasonForIndex(index), startsWith("Cannot delete indices that are being snapshotted"));
});
assertThat(getSnapshotState("snapshot"), equalTo("IN_PROGRESS"));
assertOK(client().performRequest(new Request("DELETE", "/_snapshot/repo/snapshot")));
ResponseException e = expectThrows(ResponseException.class,
() -> client().performRequest(new Request("GET", "/_snapshot/repo/snapshot")));
assertThat(e.getResponse().getStatusLine().getStatusCode(), equalTo(404));
}

public void testReadOnly() throws Exception {
createIndexWithSettings(index, Settings.builder().put(IndexMetaData.SETTING_NUMBER_OF_SHARDS, 1)
.put(IndexMetaData.SETTING_NUMBER_OF_REPLICAS, 0));
Expand Down Expand Up @@ -426,6 +468,46 @@ public void testShrinkAction() throws Exception {
expectThrows(ResponseException.class, this::indexDocument);
}

public void testShrinkDuringSnapshot() throws Exception {
// Create the repository before taking the snapshot.
Request request = new Request("PUT", "/_snapshot/repo");
request.setJsonEntity(Strings
.toString(JsonXContent.contentBuilder()
.startObject()
.field("type", "fs")
.startObject("settings")
.field("compress", randomBoolean())
.field("location", System.getProperty("tests.path.repo"))
.field("max_snapshot_bytes_per_sec", "256b")
.endObject()
.endObject()));
assertOK(client().performRequest(request));
// create delete policy
createNewSingletonPolicy("warm", new ShrinkAction(1), TimeValue.timeValueMillis(0));
// create index without policy
createIndexWithSettings(index, Settings.builder().put(IndexMetaData.SETTING_NUMBER_OF_SHARDS, 2)
.put(IndexMetaData.SETTING_NUMBER_OF_REPLICAS, 0));
// index document so snapshot actually does something
indexDocument();
// start snapshot
request = new Request("PUT", "/_snapshot/repo/snapshot");
request.addParameter("wait_for_completion", "false");
request.setJsonEntity("{\"indices\": \"" + index + "\"}");
assertOK(client().performRequest(request));
// add policy and expect it to trigger delete immediately (while snapshot in progress)
updatePolicy(index, policy);
// assert that exception was thrown
assertBusy(() -> {
assertThat(getStepKeyForIndex(index).getName(), equalTo("ERROR"));
assertThat(getReasonForIndex(index), startsWith("Cannot delete indices that are being snapshotted"));
});
assertThat(getSnapshotState("snapshot"), equalTo("IN_PROGRESS"));
assertOK(client().performRequest(new Request("DELETE", "/_snapshot/repo/snapshot")));
ResponseException e = expectThrows(ResponseException.class,
() -> client().performRequest(new Request("GET", "/_snapshot/repo/snapshot")));
assertThat(e.getResponse().getStatusLine().getStatusCode(), equalTo(404));
}

public void testFreezeAction() throws Exception {
createIndexWithSettings(index, Settings.builder().put(IndexMetaData.SETTING_NUMBER_OF_SHARDS, 1)
.put(IndexMetaData.SETTING_NUMBER_OF_REPLICAS, 0));
Expand All @@ -440,6 +522,46 @@ public void testFreezeAction() throws Exception {
});
}

public void testFreezeDuringSnapshot() throws Exception {
// Create the repository before taking the snapshot.
Request request = new Request("PUT", "/_snapshot/repo");
request.setJsonEntity(Strings
.toString(JsonXContent.contentBuilder()
.startObject()
.field("type", "fs")
.startObject("settings")
.field("compress", randomBoolean())
.field("location", System.getProperty("tests.path.repo"))
.field("max_snapshot_bytes_per_sec", "256b")
.endObject()
.endObject()));
assertOK(client().performRequest(request));
// create delete policy
createNewSingletonPolicy("cold", new FreezeAction(), TimeValue.timeValueMillis(0));
// create index without policy
createIndexWithSettings(index, Settings.builder().put(IndexMetaData.SETTING_NUMBER_OF_SHARDS, 1)
.put(IndexMetaData.SETTING_NUMBER_OF_REPLICAS, 0));
// index document so snapshot actually does something
indexDocument();
// start snapshot
request = new Request("PUT", "/_snapshot/repo/snapshot");
request.addParameter("wait_for_completion", "false");
request.setJsonEntity("{\"indices\": \"" + index + "\"}");
assertOK(client().performRequest(request));
// add policy and expect it to trigger delete immediately (while snapshot in progress)
updatePolicy(index, policy);
// assert that exception was thrown
assertBusy(() -> {
assertThat(getStepKeyForIndex(index).getName(), equalTo("ERROR"));
assertThat(getReasonForIndex(index), startsWith("Cannot close indices that are being snapshotted"));
});
assertThat(getSnapshotState("snapshot"), equalTo("IN_PROGRESS"));
assertOK(client().performRequest(new Request("DELETE", "/_snapshot/repo/snapshot")));
ResponseException e = expectThrows(ResponseException.class,
() -> client().performRequest(new Request("GET", "/_snapshot/repo/snapshot")));
assertThat(e.getResponse().getStatusLine().getStatusCode(), equalTo(404));
}

@SuppressWarnings("unchecked")
public void testNonexistentPolicy() throws Exception {
String indexPrefix = randomAlphaOfLengthBetween(5,15).toLowerCase(Locale.ROOT);
Expand Down Expand Up @@ -732,4 +854,15 @@ private void indexDocument() throws IOException {
Response response = client().performRequest(indexRequest);
logger.info(response.getStatusLine());
}

private String getSnapshotState(String snapshot) throws IOException {
Response response = client().performRequest(new Request("GET", "/_snapshot/repo/snapshot"));
Map<String, Object> responseMap;
try (InputStream is = response.getEntity().getContent()) {
responseMap = XContentHelper.convertToMap(XContentType.JSON.xContent(), is, true);
}
Map<String, Object> snapResponse = ((List<Map<String, Object>>) responseMap.get("snapshots")).get(0);
assertThat(snapResponse.get("snapshot"), equalTo("snapshot"));
return (String) snapResponse.get("state");
}
}

0 comments on commit 7aeec21

Please sign in to comment.