Skip to content

Commit

Permalink
Fix sql JdbcDocCsvSpecIT test {docs.testFilterToday} failing (#109274)
Browse files Browse the repository at this point in the history
This commit fixes an SQL test that hardcodes expected results based on today's date. The docs.testFilterToday test needs to be updated since June 2 2024, because Anneke's hire-date of 1989-06-02 (35 years ago as of time of writing) affects the expected output.
  • Loading branch information
ChrisHegarty authored Jun 3, 2024
1 parent 55101cf commit 89113e9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 8 deletions.
9 changes: 2 additions & 7 deletions muted-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ tests:
method: "testGuessIsDayFirstFromLocale"
- class: "org.elasticsearch.test.rest.ClientYamlTestSuiteIT"
issue: "https://github.com/elastic/elasticsearch/issues/108857"
method: "test {yaml=search/180_locale_dependent_mapping/Test Index and Search locale\
\ dependent mappings / dates}"
method: "test {yaml=search/180_locale_dependent_mapping/Test Index and Search locale dependent mappings / dates}"
- class: "org.elasticsearch.backwards.MixedClusterClientYamlTestSuiteIT"
issue: "https://github.com/elastic/elasticsearch/issues/108950"
method: "test {p0=health/10_basic/cluster health basic test}"
Expand All @@ -37,8 +36,7 @@ tests:
method: "testTrainedModelInference"
- class: "org.elasticsearch.xpack.security.CoreWithSecurityClientYamlTestSuiteIT"
issue: "https://github.com/elastic/elasticsearch/issues/109188"
method: "test {yaml=search/180_locale_dependent_mapping/Test Index and Search locale\
\ dependent mappings / dates}"
method: "test {yaml=search/180_locale_dependent_mapping/Test Index and Search locale dependent mappings / dates}"
- class: "org.elasticsearch.xpack.esql.qa.mixed.EsqlClientYamlIT"
issue: "https://github.com/elastic/elasticsearch/issues/109189"
method: "test {p0=esql/70_locale/Date format with Italian locale}"
Expand All @@ -57,9 +55,6 @@ tests:
- class: org.elasticsearch.analysis.common.CommonAnalysisClientYamlTestSuiteIT
method: org.elasticsearch.analysis.common.CommonAnalysisClientYamlTestSuiteIT
issue: https://github.com/elastic/elasticsearch/issues/109266
- class: "org.elasticsearch.xpack.sql.qa.single_node.JdbcDocCsvSpecIT"
issue: "https://github.com/elastic/elasticsearch/issues/109273"
method: "test {docs.testFilterToday}"

# Examples:
#
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3351,9 +3351,9 @@ SELECT first_name FROM emp WHERE hire_date > TODAY() - INTERVAL 35 YEARS ORDER B
------------
Alejandro
Amabile
Anneke
Anoosh
Basil
Bojan
// end::filterToday
;

Expand Down

0 comments on commit 89113e9

Please sign in to comment.