Skip to content

Commit

Permalink
Move versions convenience property to java plugin (#61438)
Browse files Browse the repository at this point in the history
Access the common versions map is done in a lot of places. While it can
be access through an import of VersionProperties, the vast majority of
places use it through the provided convenience property added by
BuildPlugin. This commit moves that convenience property to the base
java plugin, so further reduce dependence on the BuildPlugin.
  • Loading branch information
rjernst authored Aug 21, 2020
1 parent dabaad7 commit ab55d67
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,7 @@ class BuildPlugin implements Plugin<Project> {
configureLicenseAndNotice(project)
project.pluginManager.apply('elasticsearch.publish')
project.pluginManager.apply(DependenciesInfoPlugin)

project.extensions.getByType(ExtraPropertiesExtension).set('versions', VersionProperties.versions)

PrecommitTasks.create(project, true)
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ public void apply(Project project) {
configureJars(project);
configureJarManifest(project);
configureJavadoc(project);

// convenience access to common versions used in dependencies
project.getExtensions().getExtraProperties().set("versions", VersionProperties.getVersions());
}

/**
Expand Down

0 comments on commit ab55d67

Please sign in to comment.