Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] MockPageRecycler and MockBigArrays failures assertion failures in unrelated tests #21315

Closed
polyfractal opened this issue Nov 3, 2016 · 3 comments
Closed

[CI] MockPageRecycler and MockBigArrays failures assertion failures in unrelated tests #21315

polyfractal opened this issue Nov 3, 2016 · 3 comments
Assignees
@spinscale
Labels
:Search/Search Search-related issues that do not fall into other categories >test-failure Triaged test failures from CI

Comments

@polyfractal
Copy link
Contributor

polyfractal commented Nov 3, 2016 •
edited
Loading

Encountered a pair of failures where MockPageRecylcer and MockBigArrays failed assertions because not all pages/arrays were reclaimed. However, the tests in question don't use MockPageRecyler or MockBigArrays directly. @ywelsch suggested it may have been interference from an unrelated test, since these share state (e.g. related: #21256)

   > Throwable #1: java.lang.RuntimeException: 1 pages have not been released
   > 	at __randomizedtesting.SeedInfo.seed([EADFD0414DFC8AEC:A7DA0CF6834BD7E3]:0)
   > 	at org.elasticsearch.common.util.MockPageCacheRecycler.ensureAllPagesAreReleased(MockPageCacheRecycler.java:52)
   > 	at org.elasticsearch.test.ESTestCase.checkStaticState(ESTestCase.java:227)
   > 	at org.elasticsearch.test.ESTestCase.ensureCleanedUp(ESTestCase.java:222)
   > 	at java.lang.Thread.run(Thread.java:745)
   > Caused by: java.lang.Throwable
   > 	at org.elasticsearch.common.util.MockPageCacheRecycler.wrap(MockPageCacheRecycler.java:69)
   > 	at org.elasticsearch.common.util.MockPageCacheRecycler.bytePage(MockPageCacheRecycler.java:118)
   > 	at org.elasticsearch.common.util.BigArrays.newByteArray(BigArrays.java:466)
   > 	at org.elasticsearch.common.util.MockBigArrays.newByteArray(MockBigArrays.java:102)
   > 	at org.elasticsearch.common.util.BigArrays.newByteArray(BigArrays.java:479)
   > 	at org.elasticsearch.common.io.stream.BytesStreamOutput.<init>(BytesStreamOutput.java:62)
   > 	at org.elasticsearch.common.io.stream.ReleasableBytesStreamOutput.<init>(ReleasableBytesStreamOutput.java:36)
   > 	at org.elasticsearch.transport.TcpTransport.sendResponse(TcpTransport.java:1025)
   > 	at org.elasticsearch.transport.TcpTransportChannel.sendResponse(TcpTransportChannel.java:67)
   > 	at org.elasticsearch.transport.TcpTransportChannel.sendResponse(TcpTransportChannel.java:61)
   > 	at org.elasticsearch.transport.DelegatingTransportChannel.sendResponse(DelegatingTransportChannel.java:58)
   > 	at 

   > Throwable #1: java.lang.RuntimeException: 1 arrays have not been released
   > 	at __randomizedtesting.SeedInfo.seed([EADFD0414DFC8AEC:FC8E67EBC3395178]:0)
   > 	at org.elasticsearch.common.util.MockBigArrays.ensureAllArraysAreReleased(MockBigArrays.java:66)
   > 	at org.elasticsearch.test.ESTestCase.checkStaticState(ESTestCase.java:228)
   > 	at org.elasticsearch.test.ESTestCase.ensureCleanedUp(ESTestCase.java:222)
   > 	at java.lang.Thread.run(Thread.java:745)
@polyfractal polyfractal added the >test-failure Triaged test failures from CI label Nov 3, 2016
@imotov
Copy link
Contributor

imotov commented Nov 11, 2016

A few examples of similar failures from last night and today:

OldMonitoringIndicesBackwardsCompatibilityIT.testOldIndexes - https://internal-ci.elastic.co/job/elastic+x-plugins+master+periodic/7971/console

PermissionTests.testIndicesGlobalsIterator - https://internal-ci.elastic.co/job/elastic+x-plugins+master/1427/console

ClusterPrivilegeTests.testThatSnapshotAndRestore - https://internal-ci.elastic.co/job/elastic+x-plugins+master+periodic/7964/console

@bleskes
Copy link
Contributor

bleskes commented Nov 11, 2016

@spinscale and I talked about an option of extending the message in that throwable to see which test run while the page was acquired. Not sure how far he got with it.

@colings86 colings86 added the :Search/Search Search-related issues that do not fall into other categories label Mar 21, 2017
@cbuescher cbuescher reopened this Jun 20, 2017
@colings86 colings86 mentioned this issue Jan 24, 2018
Merged
colings86 added a commit that referenced this issue Jan 25, 2018
@colings86
Adds test name to MockPageCacheRecycler exception (#28359)
75116a2 
This change adds the test name to the exceptions thrown by the MockPageCacheRecycler and MockBigArrays. Also, if there is more than one page/array which are not released it will add the first one as the cause of the thrown exception and the others as suppressed exceptions.

Relates to #21315
colings86 added a commit that referenced this issue Jan 26, 2018
@colings86
Adds test name to MockPageCacheRecycler exception (#28359)
4596df4 
This change adds the test name to the exceptions thrown by the MockPageCacheRecycler and MockBigArrays. Also, if there is more than one page/array which are not released it will add the first one as the cause of the thrown exception and the others as suppressed exceptions.

Relates to #21315
@colings86
Copy link
Contributor

This seems to have been fixed by #27880

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spinscale spinscale

Labels
:Search/Search Search-related issues that do not fall into other categories >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@colings86 @imotov @spinscale @bleskes @polyfractal @cbuescher