Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.1 bootstrap error when setting node.local #22064

Closed
niemyjski opened this issue Dec 9, 2016 · 8 comments
Closed

5.1 bootstrap error when setting node.local #22064

niemyjski opened this issue Dec 9, 2016 · 8 comments

Comments

@niemyjski
Copy link
Contributor

I'm on Windows 10 running 5.1.1 and our single node configuration is blowing up (was working on 5.0). There is nothing in the change log about this.

https://github.com/exceptionless/Exceptionless/blob/feature/elastic5/build/elasticsearch.yml

[2016-12-08T20:44:07,655][WARN ][o.e.b.ElasticsearchUncaughtExceptionHandler] [] uncaught exception in thread [main]
org.elasticsearch.bootstrap.StartupException: java.lang.IllegalArgumentException: Unknown discovery type [local]
        at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:125) ~[elasticsearch-5.1.1.jar:5.1.1]
        at org.elasticsearch.bootstrap.Elasticsearch.execute(Elasticsearch.java:112) ~[elasticsearch-5.1.1.jar:5.1.1]
        at org.elasticsearch.cli.SettingCommand.execute(SettingCommand.java:54) ~[elasticsearch-5.1.1.jar:5.1.1]
        at org.elasticsearch.cli.Command.mainWithoutErrorHandling(Command.java:96) ~[elasticsearch-5.1.1.jar:5.1.1]
        at org.elasticsearch.cli.Command.main(Command.java:62) ~[elasticsearch-5.1.1.jar:5.1.1]
        at org.elasticsearch.bootstrap.Elasticsearch.main(Elasticsearch.java:89) ~[elasticsearch-5.1.1.jar:5.1.1]
        at org.elasticsearch.bootstrap.Elasticsearch.main(Elasticsearch.java:82) ~[elasticsearch-5.1.1.jar:5.1.1]
Caused by: java.lang.IllegalArgumentException: Unknown discovery type [local]
        at org.elasticsearch.discovery.DiscoveryModule.<init>(DiscoveryModule.java:93) ~[elasticsearch-5.1.1.jar:5.1.1]
        at org.elasticsearch.node.Node.<init>(Node.java:410) ~[elasticsearch-5.1.1.jar:5.1.1]
        at org.elasticsearch.node.Node.<init>(Node.java:229) ~[elasticsearch-5.1.1.jar:5.1.1]
        at org.elasticsearch.bootstrap.Bootstrap$6.<init>(Bootstrap.java:214) ~[elasticsearch-5.1.1.jar:5.1.1]
        at org.elasticsearch.bootstrap.Bootstrap.setup(Bootstrap.java:214) ~[elasticsearch-5.1.1.jar:5.1.1]
        at org.elasticsearch.bootstrap.Bootstrap.init(Bootstrap.java:306) ~[elasticsearch-5.1.1.jar:5.1.1]
        at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:121) ~[elasticsearch-5.1.1.jar:5.1.1]
        ... 6 more
@niemyjski niemyjski changed the title 5.1 error when setting node.local 5.1 bootstrap error when setting node.local Dec 9, 2016
@jasontedor
Copy link
Member

Your config shows discovery.type set to local, and your error message is about discovery.type local. Local discovery was in fact removed in 5.1.1 in #20960, there was no notice since it had no purpose other than in the tribe service and being used in tests when there are multiple nodes running inside the same test JVM.

Can you say what you're trying to accomplish and maybe I can point you to the right settings?

@niemyjski
Copy link
Contributor Author

niemyjski commented Dec 9, 2016

This is our config where we want to just have a node run in an isolated fashion (local only) + for tests. This should be in the release notes about a breaking change as it is breaking no mater how small it is.. It's still in your docs...

https://www.elastic.co/guide/en/elasticsearch/reference/current/breaking_50_settings_changes.html#_node_settings

And various other 3rd party websites

@jasontedor
Copy link
Member

You can just set transport.type=local, you do not need to set discovery.type=local and I think that that recommendation should be removed from docs that you link to. Also, note that local transport is removed in 6.0.0 in #20695.

jasontedor added a commit that referenced this issue Dec 9, 2016
This commit removes mention of local discovery as a replacement for
setting node.local to true.

Relates #22064
jasontedor added a commit that referenced this issue Dec 9, 2016
This commit removes mention of local discovery as a replacement for
setting node.local to true.

Relates #22064
jasontedor added a commit that referenced this issue Dec 9, 2016
This commit removes mention of local discovery as a replacement for
setting node.local to true.

Relates #22064
@jasontedor
Copy link
Member

Closed by c402333

@niemyjski
Copy link
Contributor Author

So what should we do in 6.0? I'm only asking cause every release these days breaks me and I haven't even shipped :(

@jasontedor
Copy link
Member

Why do you need to isolate the node? Why isn't binding to localhost sufficient? If not, bind to localhost and use iptables/pfctl/wf.msc to drop all traffic to the bound transport port.

@niemyjski
Copy link
Contributor Author

That will work :), I just wanted to specify it in configuration (as you previously could)

@rjernst
Copy link
Member

rjernst commented Dec 9, 2016

Setting discovery.type to none should work. This is the same that tribe node uses internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants