-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add x-opaque-id to access logs and slow logs #31521
Comments
Pinging @elastic/es-core-infra |
Add x-opaque-id to search slow logs only. Indexing slow log and audit logs will be handled as separate PRs. Relates elastic#31521
Add x-opaque-id to search slow logs only. Indexing slow log and audit logs will be handled as separate PRs. Relates #31521
I implemented it for search slow logs and spent some time today trying to apply it to the index slow logs. Unfortunately, with indexing it's not that simple. The main issue here is that indexing slow log can be reached in several different ways - original indexing on primary, as a result of replication and as a result of the recovering from the translog. And because indexing doesn't use a context object, it requires a significant plumbing effort to get id delivered to the slow log and preserved during replication and translog recovery. Since the original issue was about search, I am unsure if implementing something like this would for indexing slow log would be worth the effort. |
Add x-opaque-id to search slow logs only. Indexing slow log and audit logs will be handled as separate PRs. Relates #31521
Logs opaque_id if it is available with all audit log messages. Relates elastic#31521
Logs opaque_id if it is available with all audit log messages. Relates #31521
Logs opaque_id if it is available with all audit log messages. Relates #31521
The opaque_id is now available in audit logging as well #31878. We should discuss if want to undertake adding it to index slow log or we can close this issue. |
We discussed this and decided that there is really no compelling use case for logging opaque-id in the index slow log and a similar effect can be achieved by simply adding the id as a field to the indexed document. Therefore we are not planning to implement slow indexing log logging as part of this issue. |
Logs opaque_id if it is available with all audit log messages using index-based audit log. Closes elastic#31521
Logs opaque_id if it is available with all audit log messages using index-based audit log. Closes #31521
Logs opaque_id if it is available with all audit log messages using index-based audit log. Closes #31521
Out of FixItFriday, we decided to close #19778 in favor of this issue, which is to add the x-opaque-id to our access logs and slow logs. This will permit troublesome queries from Kibana to be tracked more accurately.
The text was updated successfully, but these errors were encountered: