Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resize should validate/carryover soft-deletes settings #33321

Closed
dnhatn opened this issue Aug 31, 2018 · 3 comments
Closed

Resize should validate/carryover soft-deletes settings #33321

dnhatn opened this issue Aug 31, 2018 · 3 comments
Assignees
@dnhatn
Labels
:Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source.

Comments

@dnhatn
Copy link
Member

dnhatn commented Aug 31, 2018

We should carryover and validate the soft-deletes settings when shrinking/splitting an index.
@dnhatn dnhatn added the :Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. label Aug 31, 2018
@dnhatn dnhatn self-assigned this Aug 31, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@jasontedor
Copy link
Member

This should be automatic starting in 7.0.0, yet requires manual intervention in the 6.x series. See #30255; in 7.0.0 copySettings can not be set to false.

@dnhatn
Copy link
Member Author

dnhatn commented Aug 31, 2018

@jasontedor Thanks for the pointer.

dnhatn added a commit that referenced this issue Aug 31, 2018
@dnhatn
TEST: Disable randomized soft-deletes settings
11b4fc8 
Tracked at #33321
@jasontedor jasontedor mentioned this issue Aug 31, 2018
Merged
@dnhatn dnhatn mentioned this issue Sep 7, 2018
Merged
dnhatn added a commit that referenced this issue Sep 10, 2018
@dnhatn
Copy and validatie soft-deletes setting on resize (#33517)
624b6bb 
This change copies and validates the soft-deletes setting during resize.
If the source enables soft-deletes, the target must also enable it.

Closes #33321
dnhatn added a commit that referenced this issue Sep 11, 2018
@dnhatn
Copy and validate soft-deletes setting on resize (#33517)
42ebc41 
This change copies and validates the soft-deletes setting during resize.
If the source enables soft-deletes, the target must also enable it.

Closes #33321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnhatn dnhatn

Labels
:Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jasontedor @dnhatn @elasticmachine