Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] GraphExploreResponseTests#testHlrcFromXContent fails #36034

Closed
cbuescher opened this issue Nov 29, 2018 · 3 comments
Closed

[CI] GraphExploreResponseTests#testHlrcFromXContent fails #36034

cbuescher opened this issue Nov 29, 2018 · 3 comments
Assignees
@polyfractal
Labels
>test-failure Triaged test failures from CI

Comments

@cbuescher
Copy link
Member

https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+intake/353/console

Error:

FAILURE 0.81s | GraphExploreResponseTests.testHlrcFromXContent <<< FAILURES!
   > Throwable #1: java.lang.AssertionError: Error when comparing xContent
[...]
at __randomizedtesting.SeedInfo.seed([2EB6774B7153F34E:9216D58F28F4F8C2]:0)
   >    at org.elasticsearch.test.hamcrest.ElasticsearchAssertions.assertToXContentEquivalent(ElasticsearchAssertions.java:678)
   >    at org.elasticsearch.test.AbstractXContentTestCase$XContentTester.test(AbstractXContentTestCase.java:125)
   >    at org.elasticsearch.test.AbstractXContentTestCase.testFromXContent(AbstractXContentTestCase.java:182)

This also reproduces locally for me on master

./gradlew :x-pack:plugin:core:test \
  -Dtests.seed=2EB6774B7153F34E \
  -Dtests.class=org.elasticsearch.protocol.xpack.graph.GraphExploreResponseTests \
  -Dtests.method="testHlrcFromXContent" \
  -Dtests.security.manager=true \
  -Dtests.locale=de \
  -Dtests.timezone=Europe/Vaduz \
  -Dcompiler.java=11 \
  -Druntime.java=8
@cbuescher cbuescher added >test-failure Triaged test failures from CI :Analytics/Graph labels Nov 29, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo

@cbuescher
Copy link
Member Author

Found another one in the old CI mails: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+multijob-unix-compatibility/os=fedora/52/console

@markharwood can you take a look? This looks similar so some earlier cases where the order of xContent deserialization is probably tested the wrong way.

I will not mute this test just yet since it seems to fail fairly rarely so far.

@jkakavas
Copy link
Member

This one failed again in https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+periodic/576/console and reproduces locally also

20:42:10 FAILURE 0.05s J5 | GraphExploreResponseTests.testHlrcFromXContent <<< FAILURES!
20:42:10    > Throwable #1: java.lang.AssertionError: Error when comparing xContent.
20:42:10    >                    connections: 

20:42:10    > 	at __randomizedtesting.SeedInfo.seed([464BC7502D9463F5:FAEB659474336879]:0)
20:42:10    > 	at org.elasticsearch.test.hamcrest.ElasticsearchAssertions.assertToXContentEquivalent(ElasticsearchAssertions.java:693)
20:42:10    > 	at org.elasticsearch.test.AbstractXContentTestCase$XContentTester.test(AbstractXContentTestCase.java:139)
20:42:10    > 	at org.elasticsearch.test.AbstractXContentTestCase.testFromXContent(AbstractXContentTestCase.java:196)
20:42:10    > 	at org.elasticsearch.protocol.AbstractHlrcXContentTestCase.testHlrcFromXContent(AbstractHlrcXContentTestCase.java:21)
20:42:10    > 	at java.lang.Thread.run(Thread.java:748)
20:42:10    > Caused by: java.lang.AssertionError: expected:<33> but was:<84>

REPRO with

./gradlew :x-pack:plugin:core:unitTest -Dtests.seed=464BC7502D9463F5 -Dtests.class=org.elasticsearch.protocol.xpack.graph.GraphExploreResponseTests -Dtests.method="testHlrcFromXContent" -Dtests.security.manager=true -Dtests.locale=es-EC -Dtests.timezone=Etc/GMT-8 -Dcompiler.java=11 -Druntime.java=8

polyfractal added a commit to polyfractal/elasticsearch that referenced this issue Feb 1, 2019
@polyfractal
testHlrcFromXContent() should respect assertToXContentEquivalence()
f1ff35d 
Tests can override assertToXContentEquivalence() in case their xcontent
cannot be directly compared (e.g. due to insertion order in maps
affecting the xcontent ordering).  But the `testHlrcFromXContent` test
hardcoded the equivalence test to `true` instead of consulting
`assertToXContentEquivalence()`

Fixes elastic#36034
@polyfractal polyfractal mentioned this issue Feb 1, 2019
Merged
polyfractal added a commit that referenced this issue Feb 5, 2019
@polyfractal
testHlrcFromXContent() should respect assertToXContentEquivalence() (#…
54e684b 
…38232)

Tests can override assertToXContentEquivalence() in case their xcontent
cannot be directly compared (e.g. due to insertion order in maps
affecting the xcontent ordering).  But the `testHlrcFromXContent` test
hardcoded the equivalence test to `true` instead of consulting
`assertToXContentEquivalence()`

Fixes #36034
polyfractal added a commit to polyfractal/elasticsearch that referenced this issue Feb 5, 2019
@polyfractal
testHlrcFromXContent() should respect assertToXContentEquivalence()
f6dab03 
Tests can override assertToXContentEquivalence() in case their xcontent
cannot be directly compared (e.g. due to insertion order in maps
affecting the xcontent ordering).  But the `testHlrcFromXContent` test
hardcoded the equivalence test to `true` instead of consulting
`assertToXContentEquivalence()`

Fixes elastic#36034
Backport of elastic#38232
@polyfractal polyfractal mentioned this issue Feb 5, 2019
Merged
polyfractal added a commit that referenced this issue Feb 8, 2019
@polyfractal
testHlrcFromXContent() should respect assertToXContentEquivalence() (#…
b4cde4b 
…38453)

Tests can override assertToXContentEquivalence() in case their xcontent
cannot be directly compared (e.g. due to insertion order in maps
affecting the xcontent ordering).  But the `testHlrcFromXContent` test
hardcoded the equivalence test to `true` instead of consulting
`assertToXContentEquivalence()`

Fixes #36034
Backport of #38232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@polyfractal polyfractal

Labels
>test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@markharwood @polyfractal @jkakavas @cbuescher @elasticmachine