Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] SetPriorityActionTests has invalid test for testNonPositivePriority #37652

Closed
markharwood opened this issue Jan 21, 2019 · 3 comments · Fixed by #38001
Closed

[CI] SetPriorityActionTests has invalid test for testNonPositivePriority #37652

markharwood opened this issue Jan 21, 2019 · 3 comments · Fixed by #38001
Assignees
@jakelandis
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >test-failure Triaged test failures from CI

Comments

@markharwood
Copy link
Contributor

Zero is a valid value according to the class under test but testNonPositivePriority is expecting an exception.

Build failure: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+g1gc/290/console

Reproduce with:

./gradlew :x-pack:plugin:core:unitTest -Dtests.seed=9FD1CC17D355FD0D -Dtests.class=org.elasticsearch.xpack.core.indexlifecycle.SetPriorityActionTests -Dtests.method="testNonPositivePriority" -Dtests.security.manager=true -Dtests.jvm.argline="-XX:-UseConcMarkSweepGC -XX:+UseG1GC" -Dtests.locale=es-DO -Dtests.timezone=Asia/Katmandu -Dcompiler.java=11 -Druntime.java=8
@markharwood markharwood added >test-failure Triaged test failures from CI :Data Management/ILM+SLM Index and Snapshot lifecycle management labels Jan 21, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

markharwood added a commit that referenced this issue Jan 21, 2019
@markharwood
Mute test
468bae2 
Tracking #37652
@markharwood
Copy link
Contributor Author

Muted in 468bae2

costin pushed a commit that referenced this issue Jan 22, 2019
@markharwood @costin
Mute test
1b85b19 
Tracking #37652

(cherry picked from commit 468bae2)
@costin
Copy link
Member

costin commented Jan 22, 2019

Cherry-picked the commit for 6.x in 1b85b19

jakelandis added a commit to jakelandis/elasticsearch that referenced this issue Jan 30, 2019
@jakelandis
ILM setPriority corrections for a 0 value
e2a4b95 
This commit fixes the test case that ensures only a priority
less then 0 is used with testNonPositivePriority. This also
allows the HLRC to support a value of 0.

Closes elastic#37652
@jakelandis jakelandis mentioned this issue Jan 30, 2019
Merged
jakelandis added a commit that referenced this issue Jan 30, 2019
@jakelandis
ILM setPriority corrections for a 0 value (#38001)
dad41c2 
This commit fixes the test case that ensures only a priority
less then 0 is used with testNonPositivePriority. This also
allows the HLRC to support a value of 0.

Closes #37652
jakelandis added a commit to jakelandis/elasticsearch that referenced this issue Jan 31, 2019
@jakelandis
ILM setPriority corrections for a 0 value (elastic#38001)
cd8d66a 
This commit fixes the test case that ensures only a priority
less then 0 is used with testNonPositivePriority. This also
allows the HLRC to support a value of 0.

Closes elastic#37652
@jakelandis jakelandis mentioned this issue Jan 31, 2019
Merged
jakelandis added a commit that referenced this issue Feb 1, 2019
@jakelandis
ILM setPriority corrections for a 0 value (#38001) (#38136)
c575cbf 
This commit fixes the test case that ensures only a priority
less then 0 is used with testNonPositivePriority. This also
allows the HLRC to support a value of 0.

Closes #37652
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakelandis jakelandis

Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ILM setPriority corrections for a 0 value jakelandis/elasticsearch
4 participants
@costin @markharwood @jakelandis @elasticmachine