Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] NoMasterNodeIT.testNoMasterActions failed #42051

Closed
bizybot opened this issue May 10, 2019 · 4 comments · Fixed by #43471
Closed

[CI] NoMasterNodeIT.testNoMasterActions failed #42051

bizybot opened this issue May 10, 2019 · 4 comments · Fixed by #43471
Assignees
@andrershov
Labels
:Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. >test-failure Triaged test failures from CI

Comments

@bizybot
Copy link
Contributor

bizybot commented May 10, 2019

NoMasterNodeIT.testNoMasterActions failed in
https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+multijob-unix-compatibility/os=opensuse/386/console

Could not reproduce locally with following:

./gradlew :server:integTest --tests "org.elasticsearch.cluster.NoMasterNodeIT.testNoMasterActions" \
  -Dtests.seed=F52513BEB5BB0A48 \
  -Dtests.security.manager=true \
  -Dtests.locale=so-DJ \
  -Dtests.timezone=Asia/Jakarta \
  -Dcompiler.java=12 \
  -Druntime.java=11

14:09:09 
14:09:09 
14:09:09 org.elasticsearch.cluster.NoMasterNodeIT > testNoMasterActions FAILED
14:09:09     java.lang.AssertionError: AcknowledgedResponse failed - not acked
14:09:09     Expected: <true>
14:09:09          but: was <false>

consoleText.txt
@bizybot bizybot added >test-failure Triaged test failures from CI :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. labels May 10, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@ywelsch
Copy link
Contributor

ywelsch commented May 10, 2019

Can you have a look @andrershov? Just quickly looking at this, we should probably have to call internalCluster().clearDisruptionScheme(); instead of disruptionScheme.stopDisrupting(); at the end of the test.

@ywelsch
Copy link
Contributor

ywelsch commented May 28, 2019

ping @andrershov

1 similar comment
@ywelsch
Copy link
Contributor

ywelsch commented Jun 18, 2019

ping @andrershov

@andrershov andrershov mentioned this issue Jun 21, 2019
Merged
andrershov added a commit that referenced this issue Jun 24, 2019
@andrershov
Fix testNoMasterActions (#43471)
cd1ed66 
This commit performs the proper restore of network disruption.
Previously disruptionScheme.stopDisrupting() was called that does not
ensure that connectivity between cluster nodes is restored. The test
was checking that the cluster has green status, but it was not checking
that connectivity between nodes is restored.
Here we switch to internalCluster().clearDisruptionScheme(true) which
performs both checks before returning.
Similar to #42798
Closes #42051
andrershov pushed a commit that referenced this issue Jun 24, 2019
Fix testNoMasterActions (#43471)
98d7d23 
This commit performs the proper restore of network disruption.
Previously disruptionScheme.stopDisrupting() was called that does not
ensure that connectivity between cluster nodes is restored. The test
was checking that the cluster has green status, but it was not checking
that connectivity between nodes is restored.
Here we switch to internalCluster().clearDisruptionScheme(true) which
performs both checks before returning.
Similar to #42798
Closes #42051

(cherry picked from commit cd1ed66)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrershov andrershov

Labels
:Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix testNoMasterActions andrershov/elasticsearch
4 participants
@andrershov @bizybot @ywelsch @elasticmachine