Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow creating index templates with : in pattern #46045

Closed
epelc opened this issue Aug 27, 2019 · 2 comments · Fixed by #56170
Closed

Disallow creating index templates with : in pattern #46045

epelc opened this issue Aug 27, 2019 · 2 comments · Fixed by #56170
Assignees
@dakrone
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates Team:Data Management Meta label for data/management team

Comments

@epelc
Copy link

epelc commented Aug 27, 2019 •
edited
Loading

Describe the feature: Stop allowing : in index pattern names for index templates. They are already disallowed in index names so why allow index_patterns to contain them? See #23892

Elasticsearch version (bin/elasticsearch --version):
7.3.1
@astefan astefan added the :Search Foundations/Mapping Index mappings, including merging and defining field types label Aug 28, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@jasontedor jasontedor added :Data Management/Indices APIs APIs to create and manage indices and templates and removed :Search Foundations/Mapping Index mappings, including merging and defining field types labels Aug 28, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@rjernst rjernst added the Team:Data Management Meta label for data/management team label May 4, 2020
@dakrone dakrone self-assigned this May 4, 2020
@dakrone dakrone mentioned this issue May 4, 2020
Merged
dakrone added a commit that referenced this issue May 5, 2020
@dakrone
Validate V2 templates more strictly (#56170)
ed271a6 
This commit changes the validation for V2 index and component templates to re-use the same
validation that V1 templates used. This includes things like invalid template names, index patterns,
etc.

This also adds validation that template names do not contain `*` and index patterns do not contain 
`:` (index names can't contain this regardless).

Supercedes #53970
Relates to #53101
Resolves #43737
Resolves #46045
dakrone added a commit to dakrone/elasticsearch that referenced this issue May 5, 2020
@dakrone
Validate V2 templates more strictly (elastic#56170)
6f77a85 
This commit changes the validation for V2 index and component templates to re-use the same
validation that V1 templates used. This includes things like invalid template names, index patterns,
etc.

This also adds validation that template names do not contain `*` and index patterns do not contain
`:` (index names can't contain this regardless).

Supercedes elastic#53970
Relates to elastic#53101
Resolves elastic#43737
Resolves elastic#46045
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dakrone dakrone

Labels
:Data Management/Indices APIs APIs to create and manage indices and templates Team:Data Management Meta label for data/management team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate V2 templates more strictly dakrone/elasticsearch
6 participants
@dakrone @rjernst @astefan @jasontedor @epelc @elasticmachine