Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elasticsearch rest-api-spec is missing the Voting Config Exclusions API #48131

Closed
nkvoll opened this issue Oct 16, 2019 · 10 comments · Fixed by #55760
Closed

Elasticsearch rest-api-spec is missing the Voting Config Exclusions API #48131

nkvoll opened this issue Oct 16, 2019 · 10 comments · Fixed by #55760
Assignees
Labels
:Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. >docs General docs changes help wanted adoptme

Comments

@nkvoll
Copy link
Member

nkvoll commented Oct 16, 2019

Voting Config Exclusions API (https://www.elastic.co/guide/en/elasticsearch/reference/master/voting-config-exclusions.html) was added in 7.0 to support graceful termination of master-eligible nodes.

It seems this API is missing from the REST API spec (https://github.com/elastic/elasticsearch/tree/master/rest-api-spec/src/main/resources/rest-api-spec/api), which means it's not part of the official clients (among potentially other things/tests)

@ywelsch ywelsch added :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. >docs General docs changes labels Oct 16, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Cluster Coordination)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@philkra
Copy link
Contributor

philkra commented Oct 17, 2019

Pinging @elastic/es-clients

@jrodewig
Copy link
Contributor

[docs issue triage]

@zacharymorn
Copy link
Contributor

@DaveCTurner I I just finished working on #51412 and this seems like a very similar issue, but just for different REST API. From what I understand this issue is to add:

  1. REST API spec
  2. A few integration tests.

Is this the right understanding?

@DaveCTurner
Copy link
Contributor

@zacharymorn I've been holding off on taking action here until the changes you've been working on in #50836 have been merged. There's no sense in documenting an API that's immediately deprecated.

@zacharymorn
Copy link
Contributor

@DaveCTurner Sorry I actually just realized that you were assigned to this task. I was browsing for issues to pick up and thought this one might be a good one, as I just finished off a similar one and have been working on #50836, hence the comment above to check for details.

@DaveCTurner
Copy link
Contributor

@zacharymorn now that #50836 is merged would you like to tackle this issue?

@zacharymorn
Copy link
Contributor

@DaveCTurner Thanks for checking! Yes I would love to pick this up.

@zacharymorn
Copy link
Contributor

@DaveCTurner I've opened a PR for this. Please let me know if it looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. >docs General docs changes help wanted adoptme
Projects
None yet
7 participants