-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elasticsearch rest-api-spec is missing the Voting Config Exclusions API #48131
Comments
Pinging @elastic/es-distributed (:Distributed/Cluster Coordination) |
Pinging @elastic/es-docs (>docs) |
Pinging @elastic/es-clients |
[docs issue triage] |
@DaveCTurner I I just finished working on #51412 and this seems like a very similar issue, but just for different REST API. From what I understand this issue is to add:
Is this the right understanding? |
@zacharymorn I've been holding off on taking action here until the changes you've been working on in #50836 have been merged. There's no sense in documenting an API that's immediately deprecated. |
@DaveCTurner Sorry I actually just realized that you were assigned to this task. I was browsing for issues to pick up and thought this one might be a good one, as I just finished off a similar one and have been working on #50836, hence the comment above to check for details. |
@zacharymorn now that #50836 is merged would you like to tackle this issue? |
@DaveCTurner Thanks for checking! Yes I would love to pick this up. |
@DaveCTurner I've opened a PR for this. Please let me know if it looks good. |
Closes #48131 Backport of #55760 Co-authored-by: zacharymorn <[email protected]>
Voting Config Exclusions API (https://www.elastic.co/guide/en/elasticsearch/reference/master/voting-config-exclusions.html) was added in 7.0 to support graceful termination of master-eligible nodes.
It seems this API is missing from the REST API spec (https://github.com/elastic/elasticsearch/tree/master/rest-api-spec/src/main/resources/rest-api-spec/api), which means it's not part of the official clients (among potentially other things/tests)
The text was updated successfully, but these errors were encountered: