Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EQL: Verification tests need improving #51873

Closed
costin opened this issue Feb 4, 2020 · 2 comments
Closed

EQL: Verification tests need improving #51873

costin opened this issue Feb 4, 2020 · 2 comments
Labels
:Analytics/EQL EQL querying

Comments

@costin
Copy link
Member

costin commented Feb 4, 2020

The current test suite for the Verifier are fairly slim (on purpose).
Going forward this needs expansion, by using more complicated datasets both from a mapping perspective (see the list here https://github.com/elastic/elasticsearch/tree/7e85fc454eb53235fe31e9a510f0fb4338b89459/x-pack/plugin/ql/src/test/resources)
and query wise (simple and complicated queries that should work or fail).
@costin costin added the :Analytics/EQL EQL querying label Feb 4, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/EQL)

@costin costin mentioned this issue Feb 4, 2020
Merged
aleksmaus added a commit to aleksmaus/elasticsearch that referenced this issue Feb 21, 2020
@aleksmaus
EQL: Expand verification tests
f12b5f9 
Fix some error messaging consistency in EqlParser

Related to elastic#51873
@aleksmaus aleksmaus mentioned this issue Feb 21, 2020
Merged
aleksmaus added a commit that referenced this issue Feb 24, 2020
@aleksmaus
EQL: Expand verification tests (#52664)
8e02bc3 
Expand verification tests
Fix some error messaging consistency in EqlParser

Related to #51873
@aleksmaus aleksmaus mentioned this issue Feb 24, 2020
Merged
@aleksmaus
Copy link
Contributor

Closing as completed now.

aleksmaus added a commit to aleksmaus/elasticsearch that referenced this issue Feb 25, 2020
@aleksmaus
EQL: Expand verification tests (elastic#52664)
05bf987 
Expand verification tests
Fix some error messaging consistency in EqlParser

Related to elastic#51873
aleksmaus added a commit that referenced this issue Feb 25, 2020
@aleksmaus
EQL: Expand verification tests (#52664) (#52725)
b2cb38c 
* EQL: Expand verification tests (#52664)

Expand verification tests
Fix some error messaging consistency in EqlParser

Related to #51873

* Adjust for 7.x compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/EQL EQL querying
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@costin @aleksmaus @elasticmachine