-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
org.elasticsearch.search.aggregations.bucket.histogram.InternalAutoDateHistogramTests.testReduceRandom fails #54540
Labels
Comments
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
hub-cap
added a commit
that referenced
this issue
Mar 31, 2020
Two more failures just now (7.6):
Can be reproduced locally with
Sample failure message:
|
Baz is muting this and I'll look in the morning. Oddly, I tracked this
particular seed failing back to December.
…On Tue, Mar 31, 2020, 19:22 Yang Wang ***@***.***> wrote:
Two more failures just now:
- https://gradle-enterprise.elastic.co/s/l5k2n2rq7sz2k
- https://gradle-enterprise.elastic.co/s/wsp272zisq7ie
Can be reproduced locally with
./gradlew ':server:test' --tests "org.elasticsearch.search.aggregations.bucket.histogram.InternalAutoDateHistogramTests.testReduceRandom" \
-Dtests.seed=7B89245A80E80B72 \
-Dtests.security.manager=true \
-Dtests.locale=es-US \
-Dtests.timezone=Australia/Broken_Hill \
-Dcompiler.java=13
Sample failure message:
:server:test » org.elasticsearch.search.aggregations.bucket.histogram.InternalAutoDateHistogramTests » testReduceRandom (0.082s)
expected:<{1583020800000=2179, 1585612800000=45}> but was:<{1583020800000=2179, 1585699200000=45}>
java.lang.AssertionError: expected:<{1583020800000=2179, 1585612800000=45}> but was:<{1583020800000=2179, 1585699200000=45}>
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#54540 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABUXIVFXMXA4Z6RCVMZ5MTRKJ3L7ANCNFSM4LYBS4IQ>
.
|
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this issue
Apr 1, 2020
The test had errors around time units that have different length - think leap years or months that aren't 30 days. This fixes those errors. In the proces I've changed a bunch of things to debug the problem: * Replace `currentTimeMillis` with a random time. Now the test fails randomly! Wonderful. Much better than on random days of the month. * Generate buckets "closer together" to test random reduction. Without this we were super frequently getting stuck in the "year of century" rounding because *some* of the of the buckets we built were far apart. This generates a much greater variety of tests. * Implement `toString` on `RoundingInfo` so I can debug without going crazy. * Switch keys in the bucket assertions from epoch millis to `Instant`s so we can read the failures. Closes elastic#54540 Closes elastic#39497
nik9000
added a commit
that referenced
this issue
Apr 2, 2020
The test had errors around time units that have different length - think leap years or months that aren't 30 days. This fixes those errors. In the proces I've changed a bunch of things to debug the problem: * Replace `currentTimeMillis` with a random time. Now the test fails randomly! Wonderful. Much better than on random days of the month. * Generate buckets "closer together" to test random reduction. Without this we were super frequently getting stuck in the "year of century" rounding because *some* of the of the buckets we built were far apart. This generates a much greater variety of tests. * Implement `toString` on `RoundingInfo` so I can debug without going crazy. * Switch keys in the bucket assertions from epoch millis to `Instant`s so we can read the failures. Closes #54540 Closes #39497
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this issue
Apr 2, 2020
The test had errors around time units that have different length - think leap years or months that aren't 30 days. This fixes those errors. In the proces I've changed a bunch of things to debug the problem: * Replace `currentTimeMillis` with a random time. Now the test fails randomly! Wonderful. Much better than on random days of the month. * Generate buckets "closer together" to test random reduction. Without this we were super frequently getting stuck in the "year of century" rounding because *some* of the of the buckets we built were far apart. This generates a much greater variety of tests. * Implement `toString` on `RoundingInfo` so I can debug without going crazy. * Switch keys in the bucket assertions from epoch millis to `Instant`s so we can read the failures. Closes elastic#54540 Closes elastic#39497
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this issue
Apr 2, 2020
The test had errors around time units that have different length - think leap years or months that aren't 30 days. This fixes those errors. In the proces I've changed a bunch of things to debug the problem: * Replace `currentTimeMillis` with a random time. Now the test fails randomly! Wonderful. Much better than on random days of the month. * Generate buckets "closer together" to test random reduction. Without this we were super frequently getting stuck in the "year of century" rounding because *some* of the of the buckets we built were far apart. This generates a much greater variety of tests. * Implement `toString` on `RoundingInfo` so I can debug without going crazy. * Switch keys in the bucket assertions from epoch millis to `Instant`s so we can read the failures. Closes elastic#54540 Closes elastic#39497
nik9000
added a commit
that referenced
this issue
Apr 3, 2020
The test had errors around time units that have different length - think leap years or months that aren't 30 days. This fixes those errors. In the proces I've changed a bunch of things to debug the problem: * Replace `currentTimeMillis` with a random time. Now the test fails randomly! Wonderful. Much better than on random days of the month. * Generate buckets "closer together" to test random reduction. Without this we were super frequently getting stuck in the "year of century" rounding because *some* of the of the buckets we built were far apart. This generates a much greater variety of tests. * Implement `toString` on `RoundingInfo` so I can debug without going crazy. * Switch keys in the bucket assertions from epoch millis to `Instant`s so we can read the failures. Closes #54540 Closes #39497
nik9000
added a commit
that referenced
this issue
Apr 3, 2020
The test had errors around time units that have different length - think leap years or months that aren't 30 days. This fixes those errors. In the proces I've changed a bunch of things to debug the problem: * Replace `currentTimeMillis` with a random time. Now the test fails randomly! Wonderful. Much better than on random days of the month. * Generate buckets "closer together" to test random reduction. Without this we were super frequently getting stuck in the "year of century" rounding because *some* of the of the buckets we built were far apart. This generates a much greater variety of tests. * Implement `toString` on `RoundingInfo` so I can debug without going crazy. * Switch keys in the bucket assertions from epoch millis to `Instant`s so we can read the failures. Closes #54540 Closes #39497
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
The text was updated successfully, but these errors were encountered: